The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-01-25 15:31:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #274 from Sonicadvance1/Fix-MD5Overflow

Browse Source 
Fix the integer overflow that happens in the MD5Sum Progressbar.
This commit is contained in:
Pierre Bourdon 2014-04-15 11:00:13 +02:00
commit 12d7ffac13
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/DolphinWX/ISOProperties.cpp
View File

@ -1208,7 +1208,7 @@ void CISOProperties::OnComputeMD5Sum(wxCommandEvent& WXUNUSED (event))
u8 output[16]; u8 output[16];
std::string output_string; std::string output_string;
std::vector<u8> data(8 * 1024 * 1024); std::vector<u8> data(8 * 1024 * 1024);
size_t read_offset = 0; u64 read_offset = 0;
md5_context ctx; md5_context ctx;
File::IOFile file(OpenGameListItem->GetFileName(), "rb"); File::IOFile file(OpenGameListItem->GetFileName(), "rb");
@ -1217,7 +1217,7 @@ void CISOProperties::OnComputeMD5Sum(wxCommandEvent& WXUNUSED (event))
wxProgressDialog progressDialog( wxProgressDialog progressDialog(
_("Computing MD5 checksum"), _("Computing MD5 checksum"),
_("Working..."), _("Working..."),
game_size, 1000,
this, this,
wxPD_APP_MODAL | wxPD_CAN_ABORT | wxPD_APP_MODAL | wxPD_CAN_ABORT |
wxPD_ELAPSED_TIME | wxPD_ESTIMATED_TIME | wxPD_REMAINING_TIME | wxPD_ELAPSED_TIME | wxPD_ESTIMATED_TIME | wxPD_REMAINING_TIME |
@ -1228,7 +1228,7 @@ void CISOProperties::OnComputeMD5Sum(wxCommandEvent& WXUNUSED (event))
while(read_offset < game_size) while(read_offset < game_size)
{ {
if (!progressDialog.Update(read_offset, _("Computing MD5 checksum"))) if (!progressDialog.Update((int)((double)read_offset / (double)game_size * 1000), _("Computing MD5 checksum")))
return; return;
size_t read_size; size_t read_size;