The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-02-15 08:49:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

DolphinQt: Reduce latency of TAS input's controller input passthrough

Browse Source 
Fixes https://bugs.dolphin-emu.org/issues/12676.

Needs testing to see if this impacts performance when controller
inputs are changing.
This commit is contained in:
JosJuice 2021-09-19 17:08:10 +02:00
parent ca064b55fe
commit 1a5e0c2084
2 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Source/Core/DolphinQt/QtUtils/QueueOnObject.h
View File

@ -17,3 +17,11 @@ static void QueueOnObject(T* obj, F&& func)
QObject src; QObject src;
QObject::connect(&src, &QObject::destroyed, obj, std::forward<F>(func), Qt::QueuedConnection); QObject::connect(&src, &QObject::destroyed, obj, std::forward<F>(func), Qt::QueuedConnection);
} }
template <typename T, typename F>
static void QueueOnObjectBlocking(T* obj, F&& func)
{
QObject src;
QObject::connect(&src, &QObject::destroyed, obj, std::forward<F>(func),
Qt::BlockingQueuedConnection);
}

12
Source/Core/DolphinQt/TAS/TASInputWindow.cpp
View File

@ -179,12 +179,12 @@ void TASInputWindow::GetButton(TASCheckBox* checkbox, UX& buttons, UX mask)
if (pressed) if (pressed)
{ {
m_checkbox_set_by_controller[checkbox] = true; m_checkbox_set_by_controller[checkbox] = true;
QueueOnObject(checkbox, [checkbox] { checkbox->setChecked(true); }); QueueOnObjectBlocking(checkbox, [checkbox] { checkbox->setChecked(true); });
} }
else if (m_checkbox_set_by_controller.count(checkbox) && m_checkbox_set_by_controller[checkbox]) else if (m_checkbox_set_by_controller.count(checkbox) && m_checkbox_set_by_controller[checkbox])
{ {
m_checkbox_set_by_controller[checkbox] = false; m_checkbox_set_by_controller[checkbox] = false;
QueueOnObject(checkbox, [checkbox] { checkbox->setChecked(false); }); QueueOnObjectBlocking(checkbox, [checkbox] { checkbox->setChecked(false); });
} }
} }
@ -202,7 +202,9 @@ void TASInputWindow::GetSpinBoxU8(QSpinBox* spin, u8& controller_value)
{ {
if (!m_spinbox_most_recent_values_u8.count(spin) || if (!m_spinbox_most_recent_values_u8.count(spin) ||
m_spinbox_most_recent_values_u8[spin] != controller_value) m_spinbox_most_recent_values_u8[spin] != controller_value)
QueueOnObject(spin, [spin, controller_value] { spin->setValue(controller_value); }); {
QueueOnObjectBlocking(spin, [spin, controller_value] { spin->setValue(controller_value); });
}
m_spinbox_most_recent_values_u8[spin] = controller_value; m_spinbox_most_recent_values_u8[spin] = controller_value;
} }
@ -220,7 +222,9 @@ void TASInputWindow::GetSpinBoxU16(QSpinBox* spin, u16& controller_value)
{ {
if (!m_spinbox_most_recent_values_u16.count(spin) || if (!m_spinbox_most_recent_values_u16.count(spin) ||
m_spinbox_most_recent_values_u16[spin] != controller_value) m_spinbox_most_recent_values_u16[spin] != controller_value)
QueueOnObject(spin, [spin, controller_value] { spin->setValue(controller_value); }); {
QueueOnObjectBlocking(spin, [spin, controller_value] { spin->setValue(controller_value); });
}
m_spinbox_most_recent_values_u16[spin] = controller_value; m_spinbox_most_recent_values_u16[spin] = controller_value;
} }