Android: Remove calling create immediately before show

This commit is contained in:
Ryan Meredith 2020-09-08 06:20:19 -04:00
parent 10e85ff40c
commit 1aacb575de
4 changed files with 6 additions and 16 deletions

View File

@ -866,8 +866,7 @@ public final class EmulationActivity extends AppCompatActivity
mEmulationFragment.refreshInputOverlay(); mEmulationFragment.refreshInputOverlay();
}); });
AlertDialog alertDialog = builder.create(); builder.show();
alertDialog.show();
} }
public void chooseDoubleTapButton() public void chooseDoubleTapButton()
@ -899,8 +898,7 @@ public final class EmulationActivity extends AppCompatActivity
mEmulationFragment.initInputPointer(); mEmulationFragment.initInputPointer();
}); });
AlertDialog alertDialog = builder.create(); builder.show();
alertDialog.show();
} }
private void adjustScale() private void adjustScale()
@ -947,8 +945,7 @@ public final class EmulationActivity extends AppCompatActivity
mEmulationFragment.refreshInputOverlay(); mEmulationFragment.refreshInputOverlay();
}); });
AlertDialog alertDialog = builder.create(); builder.show();
alertDialog.show();
} }
private void chooseController() private void chooseController()
@ -977,8 +974,7 @@ public final class EmulationActivity extends AppCompatActivity
mEmulationFragment.refreshInputOverlay(); mEmulationFragment.refreshInputOverlay();
}); });
AlertDialog alertDialog = builder.create(); builder.show();
alertDialog.show();
} }
private void showMotionControlsOptions() private void showMotionControlsOptions()
@ -1006,8 +1002,7 @@ public final class EmulationActivity extends AppCompatActivity
}); });
builder.setPositiveButton(R.string.ok, (dialogInterface, i) -> editor.apply()); builder.setPositiveButton(R.string.ok, (dialogInterface, i) -> editor.apply());
AlertDialog alertDialog = builder.create(); builder.show();
alertDialog.show();
} }
private void chooseOrientation() private void chooseOrientation()
@ -1037,8 +1032,7 @@ public final class EmulationActivity extends AppCompatActivity
updateOrientation(); updateOrientation();
}); });
AlertDialog alertDialog = builder.create(); builder.show();
alertDialog.show();
} }
private void setIRSensitivity() private void setIRSensitivity()
@ -1180,7 +1174,6 @@ public final class EmulationActivity extends AppCompatActivity
.setNegativeButton(R.string.cancel, (dialogInterface, i) -> .setNegativeButton(R.string.cancel, (dialogInterface, i) ->
{ {
}) })
.create()
.show(); .show();
} }

View File

@ -186,7 +186,6 @@ public final class SettingsActivity extends AppCompatActivity implements Setting
.setMessage(getString(R.string.game_ini_junk_question)) .setMessage(getString(R.string.game_ini_junk_question))
.setPositiveButton(R.string.yes, (dialogInterface, i) -> mPresenter.clearSettings()) .setPositiveButton(R.string.yes, (dialogInterface, i) -> mPresenter.clearSettings())
.setNegativeButton(R.string.no, null) .setNegativeButton(R.string.no, null)
.create()
.show(); .show();
} }

View File

@ -59,7 +59,6 @@ public class Analytics
sPrefsEditor.apply(); sPrefsEditor.apply();
SettingsFile.firstAnalyticsAdd(false); SettingsFile.firstAnalyticsAdd(false);
}) })
.create()
.show(); .show();
} }

View File

@ -68,7 +68,6 @@ public class PermissionsHandler
.setNegativeButton(android.R.string.cancel, (dialogInterface, i) -> .setNegativeButton(android.R.string.cancel, (dialogInterface, i) ->
Toast.makeText(activity, R.string.write_permission_needed, Toast.LENGTH_SHORT) Toast.makeText(activity, R.string.write_permission_needed, Toast.LENGTH_SHORT)
.show()) .show())
.create()
.show(); .show();
} }
} }