From 1dfeb7358911c58eaf80d2605013c34cec560ad0 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Sat, 6 Mar 2021 22:01:12 +0100 Subject: [PATCH] Force RTC bias to 0 when custom RTC is disabled too Whether the custom RTC setting is enabled shouldn't in itself affect determinism (as long as the actual RTC value is properly synced). Alters the logic added in 4b2906c. I'm not entirely certain that this is correct, but the current code doesn't really make sense to me... If we need to force the RTC bias to 0 when custom RTC is enabled, why don't we need to do it when custom RTC is disabled? The code for getting the host system's current time doesn't contain any special handling for the guest's RTC bias as far as I can tell. --- Source/Core/Core/ConfigLoaders/BaseConfigLoader.cpp | 3 +-- Source/Core/Core/HW/EXI/EXI_DeviceIPL.cpp | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Source/Core/Core/ConfigLoaders/BaseConfigLoader.cpp b/Source/Core/Core/ConfigLoaders/BaseConfigLoader.cpp index d3e340c68d..254237df9a 100644 --- a/Source/Core/Core/ConfigLoaders/BaseConfigLoader.cpp +++ b/Source/Core/Core/ConfigLoaders/BaseConfigLoader.cpp @@ -68,8 +68,7 @@ void SaveToSYSCONF(Config::LayerType layer, std::function("IPL.CB", SysConf::Entry::Type::Long, 0); + sysconf.SetData("IPL.CB", SysConf::Entry::Type::Long, 0); // Disable WiiConnect24's standby mode. If it is enabled, it prevents us from receiving // shutdown commands in the State Transition Manager (STM). diff --git a/Source/Core/Core/HW/EXI/EXI_DeviceIPL.cpp b/Source/Core/Core/HW/EXI/EXI_DeviceIPL.cpp index 0769ea41af..99177d21a2 100644 --- a/Source/Core/Core/HW/EXI/EXI_DeviceIPL.cpp +++ b/Source/Core/Core/HW/EXI/EXI_DeviceIPL.cpp @@ -136,8 +136,7 @@ CEXIIPL::CEXIIPL() // We Overwrite language selection here since it's possible on the GC to change the language as // you please g_SRAM.settings.language = SConfig::GetInstance().SelectedLanguage; - if (SConfig::GetInstance().bEnableCustomRTC) - g_SRAM.settings.rtc_bias = 0; + g_SRAM.settings.rtc_bias = 0; FixSRAMChecksums(); }