The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-01-26 07:45:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

VideoCommon/OpcodeDecoding: Make use of if constexpr

Browse Source 
We can make use of if constexpr in several scenarios here to allow
compilers to exise the relevant code paths out.

Technically a decent compiler would do this already, but now we can give
compilers a little more nudging here in the event that isn't the case.
This commit is contained in:
Lioncash 2019-12-05 08:49:05 -05:00
parent 99353c3baa
commit 1f46a6a64b
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
Source/Core/VideoCommon/OpcodeDecoding.cpp
View File

@ -124,7 +124,7 @@ u8* Run(DataReader src, u32* cycles, bool in_display_list)
const u8 sub_cmd = src.Read<u8>(); const u8 sub_cmd = src.Read<u8>();
const u32 value = src.Read<u32>(); const u32 value = src.Read<u32>();
LoadCPReg(sub_cmd, value, is_preprocess); LoadCPReg(sub_cmd, value, is_preprocess);
if (!is_preprocess) if constexpr (!is_preprocess)
INCSTAT(g_stats.this_frame.num_cp_loads); INCSTAT(g_stats.this_frame.num_cp_loads);
} }
break; break;
@ -141,7 +141,7 @@ u8* Run(DataReader src, u32* cycles, bool in_display_list)
total_cycles += 18 + 6 * transfer_size; total_cycles += 18 + 6 * transfer_size;
if (!is_preprocess) if constexpr (!is_preprocess)
{ {
const u32 xf_address = cmd2 & 0xFFFF; const u32 xf_address = cmd2 & 0xFFFF;
LoadXFReg(transfer_size, xf_address, src); LoadXFReg(transfer_size, xf_address, src);
@ -169,7 +169,7 @@ u8* Run(DataReader src, u32* cycles, bool in_display_list)
// GX_LOAD_INDX_D (56) -> 0xF // GX_LOAD_INDX_D (56) -> 0xF
const int ref_array = (cmd_byte / 8) + 8; const int ref_array = (cmd_byte / 8) + 8;
if (is_preprocess) if constexpr (is_preprocess)
PreprocessIndexedXF(src.Read<u32>(), ref_array); PreprocessIndexedXF(src.Read<u32>(), ref_array);
else else
LoadIndexedXF(src.Read<u32>(), ref_array); LoadIndexedXF(src.Read<u32>(), ref_array);
@ -191,7 +191,7 @@ u8* Run(DataReader src, u32* cycles, bool in_display_list)
} }
else else
{ {
if (is_preprocess) if constexpr (is_preprocess)
InterpretDisplayListPreprocess(address, count); InterpretDisplayListPreprocess(address, count);
else else
total_cycles += 6 + InterpretDisplayList(address, count); total_cycles += 6 + InterpretDisplayList(address, count);
@ -220,7 +220,7 @@ u8* Run(DataReader src, u32* cycles, bool in_display_list)
total_cycles += 12; total_cycles += 12;
const u32 bp_cmd = src.Read<u32>(); const u32 bp_cmd = src.Read<u32>();
if (is_preprocess) if constexpr (is_preprocess)
{ {
LoadBPRegPreprocess(bp_cmd); LoadBPRegPreprocess(bp_cmd);
} }
@ -266,10 +266,13 @@ u8* Run(DataReader src, u32* cycles, bool in_display_list)
} }
// Display lists get added directly into the FIFO stream // Display lists get added directly into the FIFO stream
if (!is_preprocess && g_record_fifo_data && cmd_byte != GX_CMD_CALL_DL) if constexpr (!is_preprocess)
{ {
const u8* const opcode_end = src.GetPointer(); if (g_record_fifo_data && cmd_byte != GX_CMD_CALL_DL)
FifoRecorder::GetInstance().WriteGPCommand(opcode_start, u32(opcode_end - opcode_start)); {
const u8* const opcode_end = src.GetPointer();
FifoRecorder::GetInstance().WriteGPCommand(opcode_start, u32(opcode_end - opcode_start));
}
} }
} }
} }