The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-01-26 07:45:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

Disable right-click menu on main window

Browse Source 
Before, right-clicking on the toolbar would allow toggling all dock widgets, including the debugger ones even when they are disabled. (See https://doc.qt.io/qt-5/qmainwindow.html#createPopupMenu for this behavior, and https://bugs.dolphin-emu.org/issues/13306 for an example of where it caused issues.)
This commit is contained in:
Pokechu22 2023-07-23 15:13:47 -07:00
parent 44c90aa3fc
commit 1f8f3840ac
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Source/Core/DolphinQt/MainWindow.cpp
View File

@ -1645,6 +1645,13 @@ bool MainWindow::eventFilter(QObject* object, QEvent* event)
return false; return false;
} }
QMenu* MainWindow::createPopupMenu()
{
// Disable the default popup menu as it exposes the debugger UI even when the debugger UI is
// disabled, which can lead to user confusion (see e.g. https://bugs.dolphin-emu.org/issues/13306)
return nullptr;
}
void MainWindow::dragEnterEvent(QDragEnterEvent* event) void MainWindow::dragEnterEvent(QDragEnterEvent* event)
{ {
if (event->mimeData()->hasUrls() && event->mimeData()->urls().size() == 1) if (event->mimeData()->hasUrls() && event->mimeData()->urls().size() == 1)

2
Source/Core/DolphinQt/MainWindow.h
View File

@ -13,6 +13,7 @@
#include "Core/Boot/Boot.h" #include "Core/Boot/Boot.h"
class QMenu;
class QStackedWidget; class QStackedWidget;
class QString; class QString;
@ -80,6 +81,7 @@ public:
WindowSystemInfo GetWindowSystemInfo() const; WindowSystemInfo GetWindowSystemInfo() const;
bool eventFilter(QObject* object, QEvent* event) override; bool eventFilter(QObject* object, QEvent* event) override;
QMenu* createPopupMenu() override;
signals: signals:
void ReadOnlyModeChanged(bool read_only); void ReadOnlyModeChanged(bool read_only);