diff --git a/Source/Core/Common/BitField.h b/Source/Core/Common/BitField.h index 10312f1c38..85a595239c 100644 --- a/Source/Core/Common/BitField.h +++ b/Source/Core/Common/BitField.h @@ -121,7 +121,7 @@ private: public: // Force default constructor to be created // so that we can use this within unions - BitField() = default; + constexpr BitField() = default; // We explicitly delete the copy assignment operator here, because the // default copy assignment would copy the full storage value, rather than @@ -139,34 +139,33 @@ public: return *this; } - __forceinline T Value() const - { - if (std::numeric_limits::is_signed) - { - std::size_t shift = 8 * sizeof(T) - bits; - return (T)((storage << (shift - position)) >> shift); - } - else - { - return (T)((storage & GetMask()) >> position); - } - } - - __forceinline operator T() const { return Value(); } + constexpr T Value() const { return Value(std::is_signed()); } + constexpr operator T() const { return Value(); } private: // StorageType is T for non-enum types and the underlying type of T if // T is an enumeration. Note that T is wrapped within an enable_if in the // former case to workaround compile errors which arise when using // std::underlying_type::type directly. - typedef typename std::conditional::value, std::underlying_type, - std::enable_if>::type::type StorageType; + using StorageType = typename std::conditional_t::value, std::underlying_type, + std::enable_if>::type; // Unsigned version of StorageType - typedef typename std::make_unsigned::type StorageTypeU; + using StorageTypeU = std::make_unsigned_t; - __forceinline StorageType GetMask() const + constexpr T Value(std::true_type) const { - return (((StorageTypeU)~0) >> (8 * sizeof(T) - bits)) << position; + using shift_amount = std::integral_constant; + return static_cast((storage << (shift_amount() - position)) >> shift_amount()); + } + + constexpr T Value(std::false_type) const + { + return static_cast((storage & GetMask()) >> position); + } + + static constexpr StorageType GetMask() + { + return (std::numeric_limits::max() >> (8 * sizeof(T) - bits)) << position; } StorageType storage;