From 81493ee91082c70af3426de5638cc1615efc209f Mon Sep 17 00:00:00 2001
From: Lioncash <mai.iam2048@gmail.com>
Date: Tue, 11 Apr 2023 09:17:00 -0400
Subject: [PATCH] NetPlayServer: Prevent unnecessary copies in
GetInterfaceSet()
This was previously copying each pair out of the vector returned by
GetInterfaceListInternal() when we just need to emplace the first entry
of each pair.
---
Source/Core/Core/NetPlayServer.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Source/Core/Core/NetPlayServer.cpp b/Source/Core/Core/NetPlayServer.cpp
index 30a2ba894a..20c54a1adf 100644
--- a/Source/Core/Core/NetPlayServer.cpp
+++ b/Source/Core/Core/NetPlayServer.cpp
@@ -2266,8 +2266,7 @@ u16 NetPlayServer::GetPort() const
std::unordered_set<std::string> NetPlayServer::GetInterfaceSet() const
{
std::unordered_set<std::string> result;
- auto lst = GetInterfaceListInternal();
- for (auto list_entry : lst)
+ for (const auto& list_entry : GetInterfaceListInternal())
result.emplace(list_entry.first);
return result;
}