From e1dfcda8a6d1b4a684e984914c888330e88180ba Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 19 Apr 2021 17:34:46 -0400 Subject: [PATCH 1/2] BlockingLoop: Add explicit [[fallthrough]] annotations --- Source/Core/Common/BlockingLoop.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Source/Core/Common/BlockingLoop.h b/Source/Core/Common/BlockingLoop.h index d4be80fe19..eafe1392cc 100644 --- a/Source/Core/Common/BlockingLoop.h +++ b/Source/Core/Common/BlockingLoop.h @@ -158,6 +158,7 @@ public: // However, if we're not in the STATE_DONE state any more, the event should also be // triggered so that we'll skip the next waiting call quite fast. m_done_event.Set(); + [[fallthrough]]; case STATE_DONE: // We're done now. So time to check if we want to sleep or if we want to stay in a busy @@ -173,6 +174,7 @@ public: // Busy loop. break; } + [[fallthrough]]; case STATE_SLEEPING: // Just relax From adebc499f9e5e160fb9d1931fc7194f793e7c40e Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 19 Apr 2021 17:36:06 -0400 Subject: [PATCH 2/2] Jit64: Indicate explicit [[fallthrough]] within load helper --- Source/Core/Core/PowerPC/Jit64/Jit_LoadStore.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Source/Core/Core/PowerPC/Jit64/Jit_LoadStore.cpp b/Source/Core/Core/PowerPC/Jit64/Jit_LoadStore.cpp index 71770840a3..d0c98a361c 100644 --- a/Source/Core/Core/PowerPC/Jit64/Jit_LoadStore.cpp +++ b/Source/Core/Core/PowerPC/Jit64/Jit_LoadStore.cpp @@ -74,6 +74,7 @@ void Jit64::lXXx(UGeckoInstruction inst) { case 534: // lwbrx byte_reversed = true; + [[fallthrough]]; case 23: // lwzx case 55: // lwzux accessSize = 32; @@ -87,6 +88,7 @@ void Jit64::lXXx(UGeckoInstruction inst) break; case 790: // lhbrx byte_reversed = true; + [[fallthrough]]; case 279: // lhzx case 311: // lhzux accessSize = 16;