From 932e3c1db2e9914367d2743deb3c66f95e552db9 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sun, 9 Mar 2014 22:55:41 -0400 Subject: [PATCH] [Android] Tidy up the dialog buttons that don't do anything. All we want to do with these is dismiss the dialog. The same can be done by simply passing null. --- .../dolphinemu/dolphinemu/emulation/EmulationActivity.java | 7 +------ .../dolphinemu/settings/video/VideoSettingsFragment.java | 6 +----- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/Source/Android/src/org/dolphinemu/dolphinemu/emulation/EmulationActivity.java b/Source/Android/src/org/dolphinemu/dolphinemu/emulation/EmulationActivity.java index 7f6896536c..cb13b9e2d6 100644 --- a/Source/Android/src/org/dolphinemu/dolphinemu/emulation/EmulationActivity.java +++ b/Source/Android/src/org/dolphinemu/dolphinemu/emulation/EmulationActivity.java @@ -255,18 +255,13 @@ public final class EmulationActivity extends Activity AlertDialog.Builder builder = new AlertDialog.Builder(this); builder.setTitle(getString(R.string.overlay_exit_emulation)); builder.setMessage(R.string.overlay_exit_emulation_confirm); + builder.setNegativeButton(R.string.no, null); builder.setPositiveButton(R.string.yes, new DialogInterface.OnClickListener() { public void onClick(DialogInterface dialog, int which) { finish(); } }); - builder.setNegativeButton(R.string.no, new DialogInterface.OnClickListener() { - public void onClick(DialogInterface dialog, int which) - { - // Do nothing. Just makes the No button appear. - } - }); builder.show(); return true; } diff --git a/Source/Android/src/org/dolphinemu/dolphinemu/settings/video/VideoSettingsFragment.java b/Source/Android/src/org/dolphinemu/dolphinemu/settings/video/VideoSettingsFragment.java index 5059fe9f39..94e411ca9e 100644 --- a/Source/Android/src/org/dolphinemu/dolphinemu/settings/video/VideoSettingsFragment.java +++ b/Source/Android/src/org/dolphinemu/dolphinemu/settings/video/VideoSettingsFragment.java @@ -107,11 +107,7 @@ public final class VideoSettingsFragment extends PreferenceFragment AlertDialog.Builder builder = new AlertDialog.Builder(getActivity()); builder.setTitle(R.string.device_compat_warning); builder.setMessage(R.string.device_gles3compat_warning_msg); - builder.setPositiveButton(R.string.yes, new DialogInterface.OnClickListener() { - public void onClick(DialogInterface dialog, int which) { - // Do Nothing. Just create the Yes button - } - }); + builder.setPositiveButton(R.string.yes, null); builder.setNegativeButton(R.string.no, new DialogInterface.OnClickListener() { public void onClick(DialogInterface dialog, int which) {