The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-02-14 00:09:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

UICommon/ResourcePack/Manager: Resolve use-after-move in Add()

Browse Source 
The pack is already has its validity checked at the beginning of the
function, so we don't need to check this again after inserting it.

Also resolves a use-after-move case.
This commit is contained in:
Lioncash 2019-05-28 17:40:24 -04:00
parent 992c8bfc4e
commit 4d2e0c7b48
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/UICommon/ResourcePack/Manager.cpp
View File

@ -128,7 +128,7 @@ bool Add(const std::string& path, int offset)
packs.insert(packs.begin() + offset, std::move(pack)); packs.insert(packs.begin() + offset, std::move(pack));
return pack.IsValid(); return true;
} }
bool Remove(ResourcePack& pack) bool Remove(ResourcePack& pack)