From 4f62960fb16eda9f4174a90bc92d5f49310a8260 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Mon, 21 Sep 2020 12:18:13 +0200 Subject: [PATCH] VolumeVerifier: Make high severity "too small" hide low severity "too small" --- Source/Core/DiscIO/VolumeVerifier.cpp | 19 +++++++++---------- Source/Core/DiscIO/VolumeVerifier.h | 1 + 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/Source/Core/DiscIO/VolumeVerifier.cpp b/Source/Core/DiscIO/VolumeVerifier.cpp index 04b285cbc4..73727ff18e 100644 --- a/Source/Core/DiscIO/VolumeVerifier.cpp +++ b/Source/Core/DiscIO/VolumeVerifier.cpp @@ -780,18 +780,9 @@ void VolumeVerifier::CheckDiscSize(const std::vector& partitions) normal_size = DL_DVD_SIZE; if (size < normal_size) - { - AddProblem( - Severity::Low, - Common::GetStringT( - "This disc image has an unusual size. This will likely make the emulated " - "loading times longer. You will likely be unable to share input recordings " - "and use NetPlay with anyone who is using a good dump.")); - } + m_smaller_than_expected = true; else - { AddProblem(Severity::Low, Common::GetStringT("This disc image has an unusual size.")); - } } } } @@ -1323,6 +1314,14 @@ void VolumeVerifier::Finish() "to merge them into one file."); AddProblem(Severity::High, std::move(text)); } + else if (m_smaller_than_expected) + { + AddProblem(Severity::Low, + Common::GetStringT( + "This disc image has an unusual size. This will likely make the emulated " + "loading times longer. You will likely be unable to share input recordings " + "and use NetPlay with anyone who is using a good dump.")); + } for (auto [partition, blocks] : m_block_errors) { diff --git a/Source/Core/DiscIO/VolumeVerifier.h b/Source/Core/DiscIO/VolumeVerifier.h index 1f045a2348..2be7949dc9 100644 --- a/Source/Core/DiscIO/VolumeVerifier.h +++ b/Source/Core/DiscIO/VolumeVerifier.h @@ -200,6 +200,7 @@ private: u64 m_biggest_referenced_offset = 0; u64 m_biggest_verified_offset = 0; + bool m_smaller_than_expected = false; bool m_started = false; bool m_done = false;