From a8a8b294cd577ba3ecd96d79f0326943e7fe5601 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Tue, 16 Nov 2021 22:45:35 +0100 Subject: [PATCH] Android: Remove all setRetainInstance calls Our reasons for using setRetainInstance were gotten rid of in PRs 9011 and 10008, so let's remove our calls to this deprecated method. --- .../dolphinemu/features/settings/ui/SettingsFragment.java | 1 - .../org/dolphinemu/dolphinemu/fragments/EmulationFragment.java | 3 --- 2 files changed, 4 deletions(-) diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragment.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragment.java index 6173d83599..9358a6f706 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragment.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragment.java @@ -100,7 +100,6 @@ public final class SettingsFragment extends Fragment implements SettingsFragment { super.onCreate(savedInstanceState); - setRetainInstance(true); Bundle args = getArguments(); MenuTag menuTag = (MenuTag) args.getSerializable(ARGUMENT_MENU_TAG); String gameId = getArguments().getString(ARGUMENT_GAME_ID); diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/EmulationFragment.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/EmulationFragment.java index 463b6ff9de..7f1e158830 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/EmulationFragment.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/EmulationFragment.java @@ -75,9 +75,6 @@ public final class EmulationFragment extends Fragment implements SurfaceHolder.C { super.onCreate(savedInstanceState); - // So this fragment doesn't restart on configuration changes; i.e. rotation. - setRetainInstance(true); - mGamePaths = getArguments().getStringArray(KEY_GAMEPATHS); mRiivolution = getArguments().getBoolean(KEY_RIIVOLUTION); }