From 316f7bfcbf41e345348a65cea4d005a8da14e3a1 Mon Sep 17 00:00:00 2001 From: Dentomologist Date: Tue, 6 Aug 2024 14:25:12 -0700 Subject: [PATCH] GeneralPane: Fix building with analytics disabled Add #if statements to only create and set analytics descriptions if analytics are enabled in the build settings. --- Source/Core/DolphinQt/Settings/GeneralPane.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Source/Core/DolphinQt/Settings/GeneralPane.cpp b/Source/Core/DolphinQt/Settings/GeneralPane.cpp index 55dc4f0799..db00c323c0 100644 --- a/Source/Core/DolphinQt/Settings/GeneralPane.cpp +++ b/Source/Core/DolphinQt/Settings/GeneralPane.cpp @@ -425,6 +425,7 @@ void GeneralPane::AddDescriptions() static constexpr char TR_FALLBACK_REGION_DESCRIPTION[] = QT_TR_NOOP("Sets the region used for titles whose region cannot be determined automatically." "

This setting cannot be changed while emulation is active."); +#if defined(USE_ANALYTICS) && USE_ANALYTICS static constexpr char TR_ENABLE_ANALYTICS_DESCRIPTION[] = QT_TR_NOOP( "If selected, Dolphin can collect data on its performance, feature usage, emulated games, " "and configuration, as well as data on your system's hardware and operating system." @@ -434,6 +435,7 @@ void GeneralPane::AddDescriptions() static constexpr char TR_GENERATE_NEW_IDENTITY_DESCRIPTION[] = QT_TR_NOOP("Generate a new anonymous ID for your usage statistics. This will cause any " "future statistics to be unassociated with your previous statistics."); +#endif m_checkbox_dualcore->SetDescription(tr(TR_DUALCORE_DESCRIPTION)); @@ -459,8 +461,10 @@ void GeneralPane::AddDescriptions() m_combobox_fallback_region->SetTitle(tr("Fallback Region")); m_combobox_fallback_region->SetDescription(tr(TR_FALLBACK_REGION_DESCRIPTION)); +#if defined(USE_ANALYTICS) && USE_ANALYTICS m_checkbox_enable_analytics->SetDescription(tr(TR_ENABLE_ANALYTICS_DESCRIPTION)); m_button_generate_new_identity->SetTitle(tr("Generate a New Statistics Identity")); m_button_generate_new_identity->SetDescription(tr(TR_GENERATE_NEW_IDENTITY_DESCRIPTION)); +#endif }