diff --git a/Source/Core/Core/IOS/FS/FileSystemCommon.cpp b/Source/Core/Core/IOS/FS/FileSystemCommon.cpp index 1ec5dbe068..fb58491588 100644 --- a/Source/Core/Core/IOS/FS/FileSystemCommon.cpp +++ b/Source/Core/Core/IOS/FS/FileSystemCommon.cpp @@ -95,8 +95,7 @@ Result FileHandle::GetStatus() const Result FileSystem::CreateAndOpenFile(Uid uid, Gid gid, const std::string& path, Modes modes) { - Result file = OpenFile(uid, gid, path, Mode::ReadWrite); - if (file.Succeeded()) + if (Result file = OpenFile(uid, gid, path, Mode::ReadWrite)) return file; const ResultCode result = CreateFile(uid, gid, path, 0, modes); diff --git a/Source/Core/DiscIO/VolumeVerifier.cpp b/Source/Core/DiscIO/VolumeVerifier.cpp index d510aa3266..6da1310f47 100644 --- a/Source/Core/DiscIO/VolumeVerifier.cpp +++ b/Source/Core/DiscIO/VolumeVerifier.cpp @@ -692,7 +692,6 @@ std::string VolumeVerifier::GetPartitionName(std::optional type) const if (!type) return "???"; - std::string name = NameForPartitionType(*type, false); if (ShouldHaveMasterpiecePartitions() && *type > 0xFF) { // i18n: This string is referring to a game mode in Super Smash Bros. Brawl called Masterpieces @@ -702,9 +701,9 @@ std::string VolumeVerifier::GetPartitionName(std::optional type) const // (French), Clásicos (Spanish), Capolavori (Italian), 클래식 게임 체험판 (Korean). // If your language is not one of the languages above, consider leaving the string untranslated // so that people will recognize it as the name of the game mode. - name = Common::FmtFormatT("{0} (Masterpiece)", name); + return Common::FmtFormatT("{0} (Masterpiece)", NameForPartitionType(*type, false)); } - return name; + return NameForPartitionType(*type, false); } bool VolumeVerifier::IsDebugSigned() const diff --git a/Source/Core/DolphinTool/ExtractCommand.cpp b/Source/Core/DolphinTool/ExtractCommand.cpp index d1daa3dd07..32d2a49d86 100644 --- a/Source/Core/DolphinTool/ExtractCommand.cpp +++ b/Source/Core/DolphinTool/ExtractCommand.cpp @@ -39,8 +39,7 @@ static std::unique_ptr GetFileInfo(const DiscIO::Volume& disc_ if (!filesystem) return nullptr; - std::unique_ptr info = filesystem->FindFileInfo(path); - return info; + return filesystem->FindFileInfo(path); } static bool VolumeSupported(const DiscIO::Volume& disc_volume) diff --git a/Source/Core/UICommon/GameFile.cpp b/Source/Core/UICommon/GameFile.cpp index 442added6e..7b9691c3a9 100644 --- a/Source/Core/UICommon/GameFile.cpp +++ b/Source/Core/UICommon/GameFile.cpp @@ -835,10 +835,9 @@ std::string GameFile::GetFileFormatName() const default: { - std::string name = DiscIO::GetName(m_blob_type, true); if (m_is_nkit) - name = Common::FmtFormatT("{0} (NKit)", name); - return name; + return Common::FmtFormatT("{0} (NKit)", DiscIO::GetName(m_blob_type, true)); + return DiscIO::GetName(m_blob_type, true); } } } diff --git a/Source/Core/VideoCommon/TextureInfo.cpp b/Source/Core/VideoCommon/TextureInfo.cpp index 5ee23f3671..27055f462d 100644 --- a/Source/Core/VideoCommon/TextureInfo.cpp +++ b/Source/Core/VideoCommon/TextureInfo.cpp @@ -183,14 +183,11 @@ TextureInfo::NameDetails TextureInfo::CalculateTextureName() const const u64 tex_hash = XXH64(m_ptr, m_texture_size, 0); const u64 tlut_hash = tlut_size ? XXH64(tlut, tlut_size, 0) : 0; - NameDetails result; - result.base_name = fmt::format("{}{}x{}{}", format_prefix, m_raw_width, m_raw_height, - m_mipmaps_enabled ? "_m" : ""); - result.texture_name = fmt::format("{:016x}", tex_hash); - result.tlut_name = tlut_size ? fmt::format("_{:016x}", tlut_hash) : ""; - result.format_name = fmt::to_string(static_cast(m_texture_format)); - - return result; + return {.base_name = fmt::format("{}{}x{}{}", format_prefix, m_raw_width, m_raw_height, + m_mipmaps_enabled ? "_m" : ""), + .texture_name = fmt::format("{:016x}", tex_hash), + .tlut_name = tlut_size ? fmt::format("_{:016x}", tlut_hash) : "", + .format_name = fmt::to_string(static_cast(m_texture_format))}; } bool TextureInfo::IsDataValid() const diff --git a/Source/Core/VideoCommon/VertexLoaderX64.cpp b/Source/Core/VideoCommon/VertexLoaderX64.cpp index aa8ad2bd67..c7cbf55257 100644 --- a/Source/Core/VideoCommon/VertexLoaderX64.cpp +++ b/Source/Core/VideoCommon/VertexLoaderX64.cpp @@ -57,11 +57,10 @@ VertexLoaderX64::VertexLoaderX64(const TVtxDesc& vtx_desc, const VAT& vtx_att) OpArg VertexLoaderX64::GetVertexAddr(CPArray array, VertexComponentFormat attribute) { - OpArg data = MDisp(src_reg, m_src_ofs); if (IsIndexed(attribute)) { int bits = attribute == VertexComponentFormat::Index8 ? 8 : 16; - LoadAndSwap(bits, scratch1, data); + LoadAndSwap(bits, scratch1, MDisp(src_reg, m_src_ofs)); m_src_ofs += bits / 8; if (array == CPArray::Position) { @@ -74,7 +73,7 @@ OpArg VertexLoaderX64::GetVertexAddr(CPArray array, VertexComponentFormat attrib } else { - return data; + return MDisp(src_reg, m_src_ofs); } }