From 585ae8aedf56b47f0535a9d9d199365ed43c6eb8 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 27 Jan 2020 15:53:25 -0500 Subject: [PATCH 1/2] DolphinQt/GCMemcardManager: Mark string as translatable within GetErrorMessagesForErrorCode() This is a string that can potentially be seen by a user, so it should be marked as translatable, like the other strings are. --- Source/Core/DolphinQt/GCMemcardManager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/DolphinQt/GCMemcardManager.cpp b/Source/Core/DolphinQt/GCMemcardManager.cpp index bc7684ee9f..571d8bad1f 100644 --- a/Source/Core/DolphinQt/GCMemcardManager.cpp +++ b/Source/Core/DolphinQt/GCMemcardManager.cpp @@ -597,7 +597,7 @@ QString GCMemcardManager::GetErrorMessagesForErrorCode(const GCMemcardErrorCode& sl.push_back(tr("Data in area of file that should be unused.")); if (sl.empty()) - return QStringLiteral("No errors."); + return tr("No errors."); return sl.join(QStringLiteral("\n")); } From 7eaa769527cce234a8e05eabcf3c4185094a9015 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 27 Jan 2020 15:59:30 -0500 Subject: [PATCH 2/2] DolphinQt/GCMemcardManager: Make use of QLatin1Char within GetErrorMessagesForErrorCode() Same behavior, but eliminates the use of a program lifetime Qt string literal. --- Source/Core/DolphinQt/GCMemcardManager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/DolphinQt/GCMemcardManager.cpp b/Source/Core/DolphinQt/GCMemcardManager.cpp index 571d8bad1f..fb1b0af4b6 100644 --- a/Source/Core/DolphinQt/GCMemcardManager.cpp +++ b/Source/Core/DolphinQt/GCMemcardManager.cpp @@ -599,5 +599,5 @@ QString GCMemcardManager::GetErrorMessagesForErrorCode(const GCMemcardErrorCode& if (sl.empty()) return tr("No errors."); - return sl.join(QStringLiteral("\n")); + return sl.join(QLatin1Char{'\n'}); }