The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-01-10 16:19:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

TASInputDlg: Fix some potential uninitialized variable warnings.

Browse Source 
Also guard against null (even if it doesn't happen it stops more warnings if someone compiles with -Wall or runs analysis with clang.
This commit is contained in:
Lioncash 2014-10-13 00:40:01 -04:00
parent 18c81dbc33
commit 6d3487aee9
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
Source/Core/DolphinWX/TASInputDlg.cpp
View File

@ -569,15 +569,18 @@ void TASInputDlg::GetValues(GCPadStatus* PadStatus)
void TASInputDlg::UpdateFromSliders(wxCommandEvent& event) void TASInputDlg::UpdateFromSliders(wxCommandEvent& event)
{ {
wxTextCtrl* text; wxTextCtrl* text = nullptr;
for (unsigned int i = 0; i < 10; ++i) for (unsigned int i = 0; i < 10; ++i)
{ {
if (Controls[i] != nullptr && event.GetId() == Controls[i]->Slider_ID) if (Controls[i] != nullptr && event.GetId() == Controls[i]->Slider_ID)
text = Controls[i]->Text; text = Controls[i]->Text;
} }
int value = ((wxSlider*) event.GetEventObject())->GetValue(); int value = ((wxSlider*) event.GetEventObject())->GetValue();
text->SetValue(std::to_string(value));
if (text)
text->SetValue(std::to_string(value));
} }
void TASInputDlg::UpdateFromText(wxCommandEvent& event) void TASInputDlg::UpdateFromText(wxCommandEvent& event)
@ -723,20 +726,29 @@ void TASInputDlg::OnMouseDownL(wxMouseEvent& event)
void TASInputDlg::SetTurbo(wxMouseEvent& event) void TASInputDlg::SetTurbo(wxMouseEvent& event)
{ {
Button* button; Button* button = nullptr;
for (unsigned int i = 0; i < 14; ++i) for (unsigned int i = 0; i < 14; ++i)
{ {
if (Buttons[i] != nullptr && event.GetId() == Buttons[i]->ID) if (Buttons[i] != nullptr && event.GetId() == Buttons[i]->ID)
button = Buttons[i]; button = Buttons[i];
} }
if (event.LeftDown()) if (event.LeftDown())
{ {
button->TurboOn = false; if (button)
button->TurboOn = false;
event.Skip(true); event.Skip(true);
return; return;
} }
button->Checkbox->SetValue(true);
button->TurboOn = !button->TurboOn; if (button)
{
button->Checkbox->SetValue(true);
button->TurboOn = !button->TurboOn;
}
event.Skip(true); event.Skip(true);
} }