The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-02-10 14:39:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix warning about compare sign mismatch

Browse Source
This commit is contained in:
Scott Mansell 2023-01-28 15:14:10 +13:00
parent 8f5b196019
commit 74d3b3443a
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/VideoCommon/BPFunctions.cpp
View File

@ -158,11 +158,11 @@ ScissorResult::ScissorResult(const BPMemory& bpmemory, std::pair<float, float> v
for (const auto& x_range : x_ranges) for (const auto& x_range : x_ranges)
{ {
DEBUG_ASSERT(x_range.start < x_range.end); DEBUG_ASSERT(x_range.start < x_range.end);
DEBUG_ASSERT(x_range.end <= EFB_WIDTH); DEBUG_ASSERT(static_cast<u32>(x_range.end) <= EFB_WIDTH);
for (const auto& y_range : y_ranges) for (const auto& y_range : y_ranges)
{ {
DEBUG_ASSERT(y_range.start < y_range.end); DEBUG_ASSERT(y_range.start < y_range.end);
DEBUG_ASSERT(y_range.end <= EFB_HEIGHT); DEBUG_ASSERT(static_cast<u32>(y_range.end) <= EFB_HEIGHT);
m_result.emplace_back(x_range, y_range); m_result.emplace_back(x_range, y_range);
} }
} }

8
Source/Core/VideoCommon/VideoCommon.h
View File

@ -12,18 +12,18 @@
#include "VideoCommon/BPMemory.h" #include "VideoCommon/BPMemory.h"
// These are accurate (disregarding AA modes). // These are accurate (disregarding AA modes).
constexpr u32 EFB_WIDTH = 640; constexpr u32 EFB_WIDTH = 640u;
constexpr u32 EFB_HEIGHT = 528; constexpr u32 EFB_HEIGHT = 528u;
// Max XFB width is 720. You can only copy out 640 wide areas of efb to XFB // Max XFB width is 720. You can only copy out 640 wide areas of efb to XFB
// so you need multiple copies to do the full width. // so you need multiple copies to do the full width.
// The VI can do horizontal scaling (TODO: emulate). // The VI can do horizontal scaling (TODO: emulate).
constexpr u32 MAX_XFB_WIDTH = 720; constexpr u32 MAX_XFB_WIDTH = 720u;
// Although EFB height is 528, 576-line XFB's can be created either with // Although EFB height is 528, 576-line XFB's can be created either with
// vertical scaling by the EFB copy operation or copying to multiple XFB's // vertical scaling by the EFB copy operation or copying to multiple XFB's
// that are next to each other in memory (TODO: handle that situation). // that are next to each other in memory (TODO: handle that situation).
constexpr u32 MAX_XFB_HEIGHT = 576; constexpr u32 MAX_XFB_HEIGHT = 576u;
#define PRIM_LOG(t, ...) DEBUG_LOG_FMT(VIDEO, t __VA_OPT__(, ) __VA_ARGS__) #define PRIM_LOG(t, ...) DEBUG_LOG_FMT(VIDEO, t __VA_OPT__(, ) __VA_ARGS__)