The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-01-26 07:45:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12526 from lioncash/trace

Browse Source 
CodeTrace: Use std::set::lower_bound() over std::lower_bound()
This commit is contained in:
JosJuice 2024-01-24 17:56:39 +01:00 committed by GitHub
commit 74d4cb0274
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Source/Core/Core/Debugger/CodeTrace.cpp
View File

@ -53,12 +53,11 @@ u32 GetMemoryTargetSize(std::string_view instr)
bool CompareMemoryTargetToTracked(const std::string& instr, const u32 mem_target, bool CompareMemoryTargetToTracked(const std::string& instr, const u32 mem_target,
const std::set<u32>& mem_tracked) const std::set<u32>& mem_tracked)
{ {
// This function is hit often and should be optimized. const auto it_lower = mem_tracked.lower_bound(mem_target);
auto it_lower = std::lower_bound(mem_tracked.begin(), mem_tracked.end(), mem_target);
if (it_lower == mem_tracked.end()) if (it_lower == mem_tracked.end())
return false; return false;
else if (*it_lower == mem_target) if (*it_lower == mem_target)
return true; return true;
// If the base value doesn't hit, still need to check if longer values overlap. // If the base value doesn't hit, still need to check if longer values overlap.