The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-02-03 19:42:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

PageFaultTest: Use GTEST_SKIP instead of early return

Browse Source 
Using GTEST_SKIP instead of just returning from the function shows that
a test was skipped in the test summary. If GTEST_SKIP is called the rest
of the function won't be run, just like with the return.

GTEST_SKIP wasn't available until gtest 1.10, and we updated to 1.12 in
597f8f1b874bf93854ae178795c55117f680e457.
This commit is contained in:
Dentomologist 2023-08-29 12:07:03 -07:00
parent 69db8a615f
commit 75a62e116c
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/UnitTests/Core/PageFaultTest.cpp
View File

@ -68,10 +68,8 @@ static void ASAN_DISABLE perform_invalid_access(void* data)
TEST(PageFault, PageFault) TEST(PageFault, PageFault)
{ {
if (!EMM::IsExceptionHandlerSupported()) if (!EMM::IsExceptionHandlerSupported())
{ GTEST_SKIP() << "Skipping PageFault test because exception handler is unsupported.";
// TODO: Use GTEST_SKIP() instead when GTest is updated to 1.10+
return;
}
EMM::InstallExceptionHandler(); EMM::InstallExceptionHandler();
void* data = Common::AllocateMemoryPages(PAGE_GRAN); void* data = Common::AllocateMemoryPages(PAGE_GRAN);
EXPECT_NE(data, nullptr); EXPECT_NE(data, nullptr);