From c8316f70a4fa398162d73291bd7469764b251c25 Mon Sep 17 00:00:00 2001 From: Shawn Hoffman Date: Sat, 9 Jan 2021 19:21:03 -0800 Subject: [PATCH 1/2] msvc: bump _MSC_FULL_VER check to 192829335 --- Source/PCH/pch.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/PCH/pch.h b/Source/PCH/pch.h index 2a2f02f3bf..e826d335ef 100644 --- a/Source/PCH/pch.h +++ b/Source/PCH/pch.h @@ -7,7 +7,7 @@ #define STRINGIFY_HELPER(x) #x #define STRINGIFY(x) STRINGIFY_HELPER(x) -#if defined _MSC_FULL_VER && _MSC_FULL_VER < 192729111 +#if defined _MSC_FULL_VER && _MSC_FULL_VER < 192829335 #pragma message("Current _MSC_FULL_VER: " STRINGIFY(_MSC_FULL_VER)) #error Please update your build environment to the latest Visual Studio 2019! #endif From cce275c16e792786701d04ee4b0f787bd928a996 Mon Sep 17 00:00:00 2001 From: Shawn Hoffman Date: Sat, 9 Jan 2021 19:22:36 -0800 Subject: [PATCH 2/2] Revert "msvc: temporary workaround for C4789 false positive" This reverts commit deb73d0167f41a172375dc41a0189863cb7a0ea8. --- Source/Core/Core/HW/WiimoteCommon/WiimoteReport.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Source/Core/Core/HW/WiimoteCommon/WiimoteReport.h b/Source/Core/Core/HW/WiimoteCommon/WiimoteReport.h index 158552b143..803e2e48ba 100644 --- a/Source/Core/Core/HW/WiimoteCommon/WiimoteReport.h +++ b/Source/Core/Core/HW/WiimoteCommon/WiimoteReport.h @@ -89,8 +89,7 @@ struct OutputReportLeds u8 rumble : 1; u8 ack : 1; - // This field must be named to work around a msvc bug. - u8 _padding : 2; + u8 : 2; u8 leds : 4; }; static_assert(sizeof(OutputReportLeds) == 1, "Wrong size");