The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-03-12 06:39:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

UICommon/NetPlayIndex: Use a std::string_view for EncryptID()/DecryptID()

Browse Source 
These parameters only acted as views into the provided strings, so these
can just be turned into non-owning string views.
This commit is contained in:
Lioncash 2019-08-04 12:32:29 -04:00
parent 2830fe820d
commit 75f3656804
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/UICommon/NetPlayIndex.cpp
View File

@ -256,7 +256,7 @@ std::vector<std::pair<std::string, std::string>> NetPlayIndex::GetRegions()
// It isn't very secure but is preferable to adding another dependency on mbedtls
// The encrypted data is encoded as nibbles with the character 'A' as the base offset
bool NetPlaySession::EncryptID(const std::string& password)
bool NetPlaySession::EncryptID(std::string_view password)
{
if (password.empty())
return false;
@ -284,7 +284,7 @@ bool NetPlaySession::EncryptID(const std::string& password)
return true;
}
std::optional<std::string> NetPlaySession::DecryptID(const std::string& password) const
std::optional<std::string> NetPlaySession::DecryptID(std::string_view password) const
{
if (password.empty())
return {};

5
Source/Core/UICommon/NetPlayIndex.h
View File

@ -8,6 +8,7 @@
#include <map>
#include <optional>
#include <string>
#include <string_view>
#include <thread>
#include <utility>
#include <vector>
@ -29,8 +30,8 @@ struct NetPlaySession
bool has_password;
bool in_game;
bool EncryptID(const std::string& password);
std::optional<std::string> DecryptID(const std::string& password) const;
bool EncryptID(std::string_view password);
std::optional<std::string> DecryptID(std::string_view password) const;
};
class NetPlayIndex