From 7f0203a5b0d61919c7e7513c2fd39c619490d392 Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Sun, 2 Apr 2017 01:45:11 -0400
Subject: [PATCH 1/4] Frame: Make TAS dialogs private

Amends the TAS callbacks to internally store functions using
std::function instead of raw function pointers. This allows binding
extra contextual state via lambda functions, as well as keeping the
dialogs internal to the main frame (on top of being a more flexible
interface).
---
 Source/Core/Core/Movie.cpp                    | 16 ++++----
 Source/Core/Core/Movie.h                      |  6 ++-
 .../Debugger/CodeWindowFunctions.cpp          |  2 +
 Source/Core/DolphinWX/Frame.cpp               | 37 +++++++++----------
 Source/Core/DolphinWX/Frame.h                 | 11 ++----
 5 files changed, 35 insertions(+), 37 deletions(-)

diff --git a/Source/Core/Core/Movie.cpp b/Source/Core/Core/Movie.cpp
index b0de9e3faa..bcd777357c 100644
--- a/Source/Core/Core/Movie.cpp
+++ b/Source/Core/Core/Movie.cpp
@@ -2,6 +2,8 @@
 // Licensed under GPLv2+
 // Refer to the license.txt file included.
 
+#include "Core/Movie.h"
+
 #include <algorithm>
 #include <array>
 #include <cctype>
@@ -10,6 +12,7 @@
 #include <mbedtls/md.h>
 #include <mutex>
 #include <thread>
+#include <utility>
 #include <vector>
 
 #include "Common/Assert.h"
@@ -34,7 +37,6 @@
 #include "Core/HW/WiimoteEmu/WiimoteHid.h"
 #include "Core/IOS/USB/Bluetooth/BTEmu.h"
 #include "Core/IOS/USB/Bluetooth/WiimoteDevice.h"
-#include "Core/Movie.h"
 #include "Core/NetPlayProto.h"
 #include "Core/PowerPC/PowerPC.h"
 #include "Core/State.h"
@@ -91,8 +93,8 @@ static bool s_bPolled = false;
 static std::mutex s_input_display_lock;
 static std::string s_InputDisplay[8];
 
-static GCManipFunction gcmfunc = nullptr;
-static WiiManipFunction wiimfunc = nullptr;
+static GCManipFunction gcmfunc;
+static WiiManipFunction wiimfunc;
 
 // NOTE: Host / CPU Thread
 static void EnsureTmpInputSize(size_t bound)
@@ -1440,25 +1442,25 @@ void SaveRecording(const std::string& filename)
 
 void SetGCInputManip(GCManipFunction func)
 {
-  gcmfunc = func;
+  gcmfunc = std::move(func);
 }
 void SetWiiInputManip(WiiManipFunction func)
 {
-  wiimfunc = func;
+  wiimfunc = std::move(func);
 }
 
 // NOTE: CPU Thread
 void CallGCInputManip(GCPadStatus* PadStatus, int controllerID)
 {
   if (gcmfunc)
-    (*gcmfunc)(PadStatus, controllerID);
+    gcmfunc(PadStatus, controllerID);
 }
 // NOTE: CPU Thread
 void CallWiiInputManip(u8* data, WiimoteEmu::ReportFeatures rptf, int controllerID, int ext,
                        const wiimote_key key)
 {
   if (wiimfunc)
-    (*wiimfunc)(data, rptf, controllerID, ext, key);
+    wiimfunc(data, rptf, controllerID, ext, key);
 }
 
 // NOTE: GPU Thread
diff --git a/Source/Core/Core/Movie.h b/Source/Core/Core/Movie.h
index e7da22d12e..30c93e2eec 100644
--- a/Source/Core/Core/Movie.h
+++ b/Source/Core/Core/Movie.h
@@ -4,6 +4,7 @@
 
 #pragma once
 
+#include <functional>
 #include <string>
 
 #include "Common/CommonTypes.h"
@@ -181,8 +182,9 @@ std::string GetInputDisplay();
 std::string GetRTCDisplay();
 
 // Done this way to avoid mixing of core and gui code
-typedef void (*GCManipFunction)(GCPadStatus*, int);
-typedef void (*WiiManipFunction)(u8*, WiimoteEmu::ReportFeatures, int, int, wiimote_key);
+using GCManipFunction = std::function<void(GCPadStatus*, int)>;
+using WiiManipFunction =
+    std::function<void(u8*, WiimoteEmu::ReportFeatures, int, int, wiimote_key)>;
 
 void SetGCInputManip(GCManipFunction);
 void SetWiiInputManip(WiiManipFunction);
diff --git a/Source/Core/DolphinWX/Debugger/CodeWindowFunctions.cpp b/Source/Core/DolphinWX/Debugger/CodeWindowFunctions.cpp
index 4c125c26e9..df287220df 100644
--- a/Source/Core/DolphinWX/Debugger/CodeWindowFunctions.cpp
+++ b/Source/Core/DolphinWX/Debugger/CodeWindowFunctions.cpp
@@ -3,7 +3,9 @@
 // Refer to the license.txt file included.
 
 #include <cstddef>
+#include <fstream>
 #include <istream>
+#include <sstream>
 #include <string>
 #include <utility>
 #include <vector>
diff --git a/Source/Core/DolphinWX/Frame.cpp b/Source/Core/DolphinWX/Frame.cpp
index a62134b8ab..830003e6c5 100644
--- a/Source/Core/DolphinWX/Frame.cpp
+++ b/Source/Core/DolphinWX/Frame.cpp
@@ -47,6 +47,7 @@
 #include "Core/HW/GCKeyboard.h"
 #include "Core/HW/GCPad.h"
 #include "Core/HW/Wiimote.h"
+#include "Core/HW/WiimoteEmu/WiimoteEmu.h"
 #include "Core/HotkeyManager.h"
 #include "Core/IOS/IPC.h"
 #include "Core/IOS/USB/Bluetooth/BTBase.h"
@@ -389,11 +390,7 @@ CFrame::CFrame(wxFrame* parent, wxWindowID id, const wxString& title, wxRect geo
   m_LogWindow->Hide();
   m_LogWindow->Disable();
 
-  for (int i = 0; i < 8; ++i)
-    g_TASInputDlg[i] = new TASInputDlg(this);
-
-  Movie::SetGCInputManip(GCTASManipFunction);
-  Movie::SetWiiInputManip(WiiTASManipFunction);
+  InitializeTASDialogs();
 
   State::SetOnAfterLoadCallback(OnAfterLoadCallback);
   Core::SetOnStoppedCallback(OnStoppedCallback);
@@ -502,6 +499,21 @@ void CFrame::BindEvents()
   Bind(DOLPHIN_EVT_STOP_SOFTWARE, &CFrame::OnStop, this);
 }
 
+void CFrame::InitializeTASDialogs()
+{
+  for (int i = 0; i < 8; ++i)
+    g_TASInputDlg[i] = new TASInputDlg(this);
+
+  Movie::SetGCInputManip([this](GCPadStatus* pad_status, int controller_id) {
+    g_TASInputDlg[controller_id]->GetValues(pad_status);
+  });
+
+  Movie::SetWiiInputManip([this](u8* data, WiimoteEmu::ReportFeatures rptf, int controller_id,
+                                 int ext, wiimote_key key) {
+    g_TASInputDlg[controller_id + 4]->GetValues(data, rptf, ext, key);
+  });
+}
+
 bool CFrame::RendererIsFullscreen()
 {
   bool fullscreen = false;
@@ -1034,21 +1046,6 @@ void OnStoppedCallback()
   }
 }
 
-void GCTASManipFunction(GCPadStatus* PadStatus, int controllerID)
-{
-  if (main_frame)
-    main_frame->g_TASInputDlg[controllerID]->GetValues(PadStatus);
-}
-
-void WiiTASManipFunction(u8* data, WiimoteEmu::ReportFeatures rptf, int controllerID, int ext,
-                         const wiimote_key key)
-{
-  if (main_frame)
-  {
-    main_frame->g_TASInputDlg[controllerID + 4]->GetValues(data, rptf, ext, key);
-  }
-}
-
 void CFrame::OnKeyDown(wxKeyEvent& event)
 {
 // On OS X, we claim all keyboard events while
diff --git a/Source/Core/DolphinWX/Frame.h b/Source/Core/DolphinWX/Frame.h
index f32973d3af..b839512440 100644
--- a/Source/Core/DolphinWX/Frame.h
+++ b/Source/Core/DolphinWX/Frame.h
@@ -16,9 +16,7 @@
 
 #include "Common/CommonTypes.h"
 #include "Common/Event.h"
-#include "Core/HW/WiimoteEmu/WiimoteEmu.h"
 #include "DolphinWX/Globals.h"
-#include "InputCommon/GCPadStatus.h"
 
 #if defined(HAVE_X11) && HAVE_X11
 #include "UICommon/X11Utils.h"
@@ -88,7 +86,6 @@ public:
   CCodeWindow* g_pCodeWindow = nullptr;
   NetPlaySetupFrame* g_NetPlaySetupDiag = nullptr;
   wxCheatsWindow* g_CheatsWindow = nullptr;
-  TASInputDlg* g_TASInputDlg[8];
 
   void DoStop();
   void UpdateGUI();
@@ -140,6 +137,7 @@ private:
   CLogWindow* m_LogWindow = nullptr;
   LogConfigWindow* m_LogConfigWindow = nullptr;
   FifoPlayerDlg* m_FifoPlayerDlg = nullptr;
+  TASInputDlg* g_TASInputDlg[8];
   bool UseDebugger = false;
   bool m_bBatchMode = false;
   bool m_bEdit = false;
@@ -174,6 +172,8 @@ private:
   wxToolBar* OnCreateToolBar(long style, wxWindowID id, const wxString& name) override;
   wxMenuBar* CreateMenuBar() const;
 
+  void InitializeTASDialogs();
+
   // Utility
   wxWindow* GetNotebookPageFromId(wxWindowID Id);
   wxAuiNotebook* GetNotebookFromId(u32 NBId);
@@ -339,8 +339,3 @@ private:
 
 void OnAfterLoadCallback();
 void OnStoppedCallback();
-
-// For TASInputDlg
-void GCTASManipFunction(GCPadStatus* PadStatus, int controllerID);
-void WiiTASManipFunction(u8* data, WiimoteEmu::ReportFeatures rptf, int controllerID, int ext,
-                         const wiimote_key key);

From 678905764a6e8d04c092892f39ece8c263f3d545 Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Sun, 2 Apr 2017 02:34:38 -0400
Subject: [PATCH 2/4] Movie/Frame: Amend variable naming

Amends variable naming related to translation unit locals and TAS input
dialogs that were modified in the previous commit.
---
 Source/Core/Core/Movie.cpp           | 16 ++++++++--------
 Source/Core/DolphinWX/Frame.cpp      |  6 +++---
 Source/Core/DolphinWX/Frame.h        |  2 +-
 Source/Core/DolphinWX/FrameTools.cpp | 13 +++++++------
 4 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/Source/Core/Core/Movie.cpp b/Source/Core/Core/Movie.cpp
index bcd777357c..9e4ef23607 100644
--- a/Source/Core/Core/Movie.cpp
+++ b/Source/Core/Core/Movie.cpp
@@ -93,8 +93,8 @@ static bool s_bPolled = false;
 static std::mutex s_input_display_lock;
 static std::string s_InputDisplay[8];
 
-static GCManipFunction gcmfunc;
-static WiiManipFunction wiimfunc;
+static GCManipFunction s_gc_manip_func;
+static WiiManipFunction s_wii_manip_func;
 
 // NOTE: Host / CPU Thread
 static void EnsureTmpInputSize(size_t bound)
@@ -1442,25 +1442,25 @@ void SaveRecording(const std::string& filename)
 
 void SetGCInputManip(GCManipFunction func)
 {
-  gcmfunc = std::move(func);
+  s_gc_manip_func = std::move(func);
 }
 void SetWiiInputManip(WiiManipFunction func)
 {
-  wiimfunc = std::move(func);
+  s_wii_manip_func = std::move(func);
 }
 
 // NOTE: CPU Thread
 void CallGCInputManip(GCPadStatus* PadStatus, int controllerID)
 {
-  if (gcmfunc)
-    gcmfunc(PadStatus, controllerID);
+  if (s_gc_manip_func)
+    s_gc_manip_func(PadStatus, controllerID);
 }
 // NOTE: CPU Thread
 void CallWiiInputManip(u8* data, WiimoteEmu::ReportFeatures rptf, int controllerID, int ext,
                        const wiimote_key key)
 {
-  if (wiimfunc)
-    wiimfunc(data, rptf, controllerID, ext, key);
+  if (s_wii_manip_func)
+    s_wii_manip_func(data, rptf, controllerID, ext, key);
 }
 
 // NOTE: GPU Thread
diff --git a/Source/Core/DolphinWX/Frame.cpp b/Source/Core/DolphinWX/Frame.cpp
index 830003e6c5..73d4c497bd 100644
--- a/Source/Core/DolphinWX/Frame.cpp
+++ b/Source/Core/DolphinWX/Frame.cpp
@@ -502,15 +502,15 @@ void CFrame::BindEvents()
 void CFrame::InitializeTASDialogs()
 {
   for (int i = 0; i < 8; ++i)
-    g_TASInputDlg[i] = new TASInputDlg(this);
+    m_tas_input_dialogs[i] = new TASInputDlg(this);
 
   Movie::SetGCInputManip([this](GCPadStatus* pad_status, int controller_id) {
-    g_TASInputDlg[controller_id]->GetValues(pad_status);
+    m_tas_input_dialogs[controller_id]->GetValues(pad_status);
   });
 
   Movie::SetWiiInputManip([this](u8* data, WiimoteEmu::ReportFeatures rptf, int controller_id,
                                  int ext, wiimote_key key) {
-    g_TASInputDlg[controller_id + 4]->GetValues(data, rptf, ext, key);
+    m_tas_input_dialogs[controller_id + 4]->GetValues(data, rptf, ext, key);
   });
 }
 
diff --git a/Source/Core/DolphinWX/Frame.h b/Source/Core/DolphinWX/Frame.h
index b839512440..eec1ee0ab8 100644
--- a/Source/Core/DolphinWX/Frame.h
+++ b/Source/Core/DolphinWX/Frame.h
@@ -137,7 +137,7 @@ private:
   CLogWindow* m_LogWindow = nullptr;
   LogConfigWindow* m_LogConfigWindow = nullptr;
   FifoPlayerDlg* m_FifoPlayerDlg = nullptr;
-  TASInputDlg* g_TASInputDlg[8];
+  TASInputDlg* m_tas_input_dialogs[8];
   bool UseDebugger = false;
   bool m_bBatchMode = false;
   bool m_bEdit = false;
diff --git a/Source/Core/DolphinWX/FrameTools.cpp b/Source/Core/DolphinWX/FrameTools.cpp
index 58986f4fe0..218556d739 100644
--- a/Source/Core/DolphinWX/FrameTools.cpp
+++ b/Source/Core/DolphinWX/FrameTools.cpp
@@ -369,17 +369,18 @@ void CFrame::OnTASInput(wxCommandEvent& event)
     if (SConfig::GetInstance().m_SIDevice[i] != SerialInterface::SIDEVICE_NONE &&
         SConfig::GetInstance().m_SIDevice[i] != SerialInterface::SIDEVICE_GC_GBA)
     {
-      g_TASInputDlg[i]->CreateGCLayout();
-      g_TASInputDlg[i]->Show();
-      g_TASInputDlg[i]->SetTitle(wxString::Format(_("TAS Input - GameCube Controller %d"), i + 1));
+      m_tas_input_dialogs[i]->CreateGCLayout();
+      m_tas_input_dialogs[i]->Show();
+      m_tas_input_dialogs[i]->SetTitle(
+          wxString::Format(_("TAS Input - GameCube Controller %d"), i + 1));
     }
 
     if (g_wiimote_sources[i] == WIIMOTE_SRC_EMU &&
         !(Core::IsRunning() && !SConfig::GetInstance().bWii))
     {
-      g_TASInputDlg[i + 4]->CreateWiiLayout(i);
-      g_TASInputDlg[i + 4]->Show();
-      g_TASInputDlg[i + 4]->SetTitle(wxString::Format(_("TAS Input - Wii Remote %d"), i + 1));
+      m_tas_input_dialogs[i + 4]->CreateWiiLayout(i);
+      m_tas_input_dialogs[i + 4]->Show();
+      m_tas_input_dialogs[i + 4]->SetTitle(wxString::Format(_("TAS Input - Wii Remote %d"), i + 1));
     }
   }
 }

From c09f7bd84b84f462c4940239e9e3c08274d7e3b4 Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Sun, 2 Apr 2017 03:04:50 -0400
Subject: [PATCH 3/4] Frame: Convert TAS dialog C array to std::array

---
 Source/Core/DolphinWX/Frame.cpp | 5 +++--
 Source/Core/DolphinWX/Frame.h   | 3 ++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/Source/Core/DolphinWX/Frame.cpp b/Source/Core/DolphinWX/Frame.cpp
index 73d4c497bd..0675d4ad32 100644
--- a/Source/Core/DolphinWX/Frame.cpp
+++ b/Source/Core/DolphinWX/Frame.cpp
@@ -4,6 +4,7 @@
 
 #include "DolphinWX/Frame.h"
 
+#include <algorithm>
 #include <atomic>
 #include <cstddef>
 #include <fstream>
@@ -501,8 +502,8 @@ void CFrame::BindEvents()
 
 void CFrame::InitializeTASDialogs()
 {
-  for (int i = 0; i < 8; ++i)
-    m_tas_input_dialogs[i] = new TASInputDlg(this);
+  std::generate(m_tas_input_dialogs.begin(), m_tas_input_dialogs.end(),
+                [this] { return new TASInputDlg{this}; });
 
   Movie::SetGCInputManip([this](GCPadStatus* pad_status, int controller_id) {
     m_tas_input_dialogs[controller_id]->GetValues(pad_status);
diff --git a/Source/Core/DolphinWX/Frame.h b/Source/Core/DolphinWX/Frame.h
index eec1ee0ab8..ea76cc360b 100644
--- a/Source/Core/DolphinWX/Frame.h
+++ b/Source/Core/DolphinWX/Frame.h
@@ -4,6 +4,7 @@
 
 #pragma once
 
+#include <array>
 #include <cstddef>
 #include <mutex>
 #include <string>
@@ -137,7 +138,7 @@ private:
   CLogWindow* m_LogWindow = nullptr;
   LogConfigWindow* m_LogConfigWindow = nullptr;
   FifoPlayerDlg* m_FifoPlayerDlg = nullptr;
-  TASInputDlg* m_tas_input_dialogs[8];
+  std::array<TASInputDlg*, 8> m_tas_input_dialogs{};
   bool UseDebugger = false;
   bool m_bBatchMode = false;
   bool m_bEdit = false;

From 05872336a9bfc6214f4e818aa76ea1e9bb063dcd Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Sun, 2 Apr 2017 06:13:12 -0400
Subject: [PATCH 4/4] ExpressionParser: Rename ParseStatus' Success member to
 Successful

This clashes with X11's preprocessor define named Success (because using
non-prefixed lowercase identifiers in C was apparently a fantastic idea
at some point), causing compilation errors.
---
 .../Core/DolphinWX/Input/InputConfigDiag.cpp  |  2 +-
 .../ControlReference/ExpressionParser.cpp     | 26 +++++++++----------
 .../ControlReference/ExpressionParser.h       |  2 +-
 3 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/Source/Core/DolphinWX/Input/InputConfigDiag.cpp b/Source/Core/DolphinWX/Input/InputConfigDiag.cpp
index 6e3ca5bb1b..46673ac478 100644
--- a/Source/Core/DolphinWX/Input/InputConfigDiag.cpp
+++ b/Source/Core/DolphinWX/Input/InputConfigDiag.cpp
@@ -407,7 +407,7 @@ bool ControlDialog::Validate()
   UpdateGUI();
 
   const auto parse_status = control_reference->GetParseStatus();
-  return parse_status == ParseStatus::Success || parse_status == ParseStatus::NoDevice;
+  return parse_status == ParseStatus::Successful || parse_status == ParseStatus::NoDevice;
 }
 
 void InputConfigDialog::SetDevice(wxCommandEvent&)
diff --git a/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp b/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp
index 0cb70970d0..d520015cf3 100644
--- a/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp
+++ b/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp
@@ -203,7 +203,7 @@ public:
       if (tok.type == TOK_EOF)
         break;
     }
-    return ParseStatus::Success;
+    return ParseStatus::Successful;
   }
 };
 
@@ -373,11 +373,11 @@ public:
   {
     ExpressionNode* node;
     ParseStatus status = Toplevel(&node);
-    if (status != ParseStatus::Success)
+    if (status != ParseStatus::Successful)
       return status;
 
     *expr_out = new Expression(node);
-    return ParseStatus::Success;
+    return ParseStatus::Successful;
   }
 
 private:
@@ -409,7 +409,7 @@ private:
       }
 
       *expr_out = new ControlExpression(tok.qualifier, device, control);
-      return ParseStatus::Success;
+      return ParseStatus::Successful;
     }
     case TOK_LPAREN:
       return Paren(expr_out);
@@ -439,7 +439,7 @@ private:
       if (status == ParseStatus::SyntaxError)
         return status;
       *expr_out = new UnaryExpression(tok.type, atom_expr);
-      return ParseStatus::Success;
+      return ParseStatus::Successful;
     }
 
     return Atom(expr_out);
@@ -478,7 +478,7 @@ private:
       *expr_out = new BinaryExpression(tok.type, *expr_out, unary_expr);
     }
 
-    return ParseStatus::Success;
+    return ParseStatus::Successful;
   }
 
   ParseStatus Paren(ExpressionNode** expr_out)
@@ -486,7 +486,7 @@ private:
     ParseStatus status;
 
     // lparen already chewed
-    if ((status = Toplevel(expr_out)) != ParseStatus::Success)
+    if ((status = Toplevel(expr_out)) != ParseStatus::Successful)
       return status;
 
     if (!Expects(TOK_RPAREN))
@@ -495,7 +495,7 @@ private:
       return ParseStatus::SyntaxError;
     }
 
-    return ParseStatus::Success;
+    return ParseStatus::Successful;
   }
 
   ParseStatus Toplevel(ExpressionNode** expr_out) { return Binary(expr_out); }
@@ -530,21 +530,21 @@ static ParseStatus ParseExpressionInner(const std::string& str, ControlFinder& f
   *expr_out = nullptr;
 
   if (str == "")
-    return ParseStatus::Success;
+    return ParseStatus::Successful;
 
   Lexer l(str);
   std::vector<Token> tokens;
   status = l.Tokenize(tokens);
-  if (status != ParseStatus::Success)
+  if (status != ParseStatus::Successful)
     return status;
 
   Parser p(tokens, finder);
   status = p.Parse(&expr);
-  if (status != ParseStatus::Success)
+  if (status != ParseStatus::Successful)
     return status;
 
   *expr_out = expr;
-  return ParseStatus::Success;
+  return ParseStatus::Successful;
 }
 
 ParseStatus ParseExpression(const std::string& str, ControlFinder& finder, Expression** expr_out)
@@ -561,7 +561,7 @@ ParseStatus ParseExpression(const std::string& str, ControlFinder& finder, Expre
   if (control)
   {
     *expr_out = new Expression(new ControlExpression(qualifier, device, control));
-    return ParseStatus::Success;
+    return ParseStatus::Successful;
   }
 
   return ParseExpressionInner(str, finder, expr_out);
diff --git a/Source/Core/InputCommon/ControlReference/ExpressionParser.h b/Source/Core/InputCommon/ControlReference/ExpressionParser.h
index 2681c551fc..f07c9a1326 100644
--- a/Source/Core/InputCommon/ControlReference/ExpressionParser.h
+++ b/Source/Core/InputCommon/ControlReference/ExpressionParser.h
@@ -61,7 +61,7 @@ public:
 
 enum class ParseStatus
 {
-  Success,
+  Successful,
   SyntaxError,
   NoDevice,
 };