From 8c8bd0e7ac5fbe8868031ff5c75e387d9df89338 Mon Sep 17 00:00:00 2001 From: Scott Mansell Date: Fri, 3 Feb 2023 13:37:42 +1300 Subject: [PATCH] Rename to HookableEvent. Because naming conflict --- Source/Core/Common/CMakeLists.txt | 2 +- Source/Core/Common/{EventHook.h => HookableEvent.h} | 6 +++--- Source/Core/Core/FifoPlayer/FifoRecorder.h | 2 +- Source/Core/DolphinLib.props | 2 +- Source/Core/VideoCommon/VideoEvents.h | 12 ++++++------ 5 files changed, 12 insertions(+), 12 deletions(-) rename Source/Core/Common/{EventHook.h => HookableEvent.h} (92%) diff --git a/Source/Core/Common/CMakeLists.txt b/Source/Core/Common/CMakeLists.txt index bab78766da..30248f864f 100644 --- a/Source/Core/Common/CMakeLists.txt +++ b/Source/Core/Common/CMakeLists.txt @@ -46,7 +46,6 @@ add_library(common EnumFormatter.h EnumMap.h Event.h - EventHook.h FatFsUtil.cpp FatFsUtil.h FileSearch.cpp @@ -63,6 +62,7 @@ add_library(common GekkoDisassembler.h Hash.cpp Hash.h + HookableEvent.h HttpRequest.cpp HttpRequest.h Image.cpp diff --git a/Source/Core/Common/EventHook.h b/Source/Core/Common/HookableEvent.h similarity index 92% rename from Source/Core/Common/EventHook.h rename to Source/Core/Common/HookableEvent.h index 49a3b9514a..cc58c045b5 100644 --- a/Source/Core/Common/EventHook.h +++ b/Source/Core/Common/HookableEvent.h @@ -19,7 +19,7 @@ namespace Common // Define Events in a header as: // -// using MyLoveyEvent = Event<"My lovely event", std::string>; +// using MyLoveyEvent = HookableEvent<"My lovely event", std::string>; // // Register listeners anywhere you need them as: // EventHook myHook = MyLoveyEvent::Register([](std::string foo) { @@ -40,7 +40,7 @@ struct HookBase using EventHook = std::unique_ptr; template -class Event +class HookableEvent { public: using CallbackType = std::function; @@ -48,7 +48,7 @@ public: private: struct HookImpl final : public HookBase { - ~HookImpl() override { Event::Remove(this); } + ~HookImpl() override { HookableEvent::Remove(this); } HookImpl(CallbackType callback, std::string name) : m_fn(std::move(callback)), m_name(std::move(name)) { diff --git a/Source/Core/Core/FifoPlayer/FifoRecorder.h b/Source/Core/Core/FifoPlayer/FifoRecorder.h index c0a1845471..b6330c2e28 100644 --- a/Source/Core/Core/FifoPlayer/FifoRecorder.h +++ b/Source/Core/Core/FifoPlayer/FifoRecorder.h @@ -9,7 +9,7 @@ #include #include "Common/Assert.h" -#include "Common/EventHook.h" +#include "Common/HookableEvent.h" #include "Core/FifoPlayer/FifoDataFile.h" class FifoRecorder diff --git a/Source/Core/DolphinLib.props b/Source/Core/DolphinLib.props index 780f8da7b9..ff461840e3 100644 --- a/Source/Core/DolphinLib.props +++ b/Source/Core/DolphinLib.props @@ -46,7 +46,6 @@ - @@ -110,6 +109,7 @@ + diff --git a/Source/Core/VideoCommon/VideoEvents.h b/Source/Core/VideoCommon/VideoEvents.h index 57d44cbe59..a54d4d9ce7 100644 --- a/Source/Core/VideoCommon/VideoEvents.h +++ b/Source/Core/VideoCommon/VideoEvents.h @@ -4,19 +4,19 @@ #pragma once #include "Common/CommonTypes.h" -#include "Common/EventHook.h" +#include "Common/HookableEvent.h" // Called when certain video config setting are changed -using ConfigChangedEvent = Common::Event<"ConfigChanged", u32>; +using ConfigChangedEvent = Common::HookableEvent<"ConfigChanged", u32>; // An event called just before the first draw call of a frame -using BeforeFrameEvent = Common::Event<"BeforeFrame">; +using BeforeFrameEvent = Common::HookableEvent<"BeforeFrame">; // An event called after the frame XFB copy begins processing on the host GPU. // Useful for "once per frame" usecases. // Note: In a few rare cases, games do multiple XFB copies per frame and join them while presenting. // If this matters to your usecase, you should use BeforePresent instead. -using AfterFrameEvent = Common::Event<"AfterFrame">; +using AfterFrameEvent = Common::HookableEvent<"AfterFrame">; struct PresentInfo { @@ -76,8 +76,8 @@ struct PresentInfo // frame. // // frame_count: The number of frames -using BeforePresentEvent = Common::Event<"BeforePresent", PresentInfo&>; +using BeforePresentEvent = Common::HookableEvent<"BeforePresent", PresentInfo&>; // An event that is triggered after a frame is presented. // The exact timing of this event depends on backend/driver support. -using AfterPresentEvent = Common::Event<"AfterPresent", PresentInfo&>; +using AfterPresentEvent = Common::HookableEvent<"AfterPresent", PresentInfo&>;