The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-01-10 08:09:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

UICommon/GameFile: Default no-arg constructor and destructor within the cpp file

Browse Source 
A GameFile instance contains quite a lot of non-trivial types, so
default construction and destruction in the same translation unit.
This commit is contained in:
Lioncash 2019-05-28 05:53:36 -04:00
parent 49ca31467d
commit 8e65869484
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/UICommon/GameFile.cpp
View File

@ -111,6 +111,8 @@ GameFile::LookupUsingConfigLanguage(const std::map<DiscIO::Language, std::string
return Lookup(GetConfigLanguage(), strings); return Lookup(GetConfigLanguage(), strings);
} }
GameFile::GameFile() = default;
GameFile::GameFile(const std::string& path) : m_file_path(path) GameFile::GameFile(const std::string& path) : m_file_path(path)
{ {
{ {
@ -159,6 +161,8 @@ GameFile::GameFile(const std::string& path) : m_file_path(path)
} }
} }
GameFile::~GameFile() = default;
bool GameFile::IsValid() const bool GameFile::IsValid() const
{ {
if (!m_valid) if (!m_valid)

4
Source/Core/UICommon/GameFile.h
View File

@ -44,9 +44,9 @@ bool operator!=(const GameBanner& lhs, const GameBanner& rhs);
class GameFile final class GameFile final
{ {
public: public:
GameFile() = default; GameFile();
explicit GameFile(const std::string& path); explicit GameFile(const std::string& path);
~GameFile() = default; ~GameFile();
bool IsValid() const; bool IsValid() const;
const std::string& GetFilePath() const { return m_file_path; } const std::string& GetFilePath() const { return m_file_path; }