Merge pull request #9904 from shuffle2/msvc-volatile-ut

unittests: remove some msvc-specific casts
This commit is contained in:
Tilka 2021-07-18 02:20:31 +01:00 committed by GitHub
commit 8feff42338
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -28,10 +28,8 @@ TEST(FloatUtils, FlushToZero)
// we want the multiplication to occur at test runtime. // we want the multiplication to occur at test runtime.
volatile float s = std::numeric_limits<float>::denorm_min(); volatile float s = std::numeric_limits<float>::denorm_min();
volatile double d = std::numeric_limits<double>::denorm_min(); volatile double d = std::numeric_limits<double>::denorm_min();
// Casting away the volatile attribute is required in order for msvc to resolve this to the EXPECT_LT(0.f, s * 2);
// correct instance of the comparison function. EXPECT_LT(0.0, d * 2);
EXPECT_LT(0.f, (float)(s * 2));
EXPECT_LT(0.0, (double)(d * 2));
EXPECT_EQ(+0.0, Common::FlushToZero(+std::numeric_limits<double>::denorm_min())); EXPECT_EQ(+0.0, Common::FlushToZero(+std::numeric_limits<double>::denorm_min()));
EXPECT_EQ(-0.0, Common::FlushToZero(-std::numeric_limits<double>::denorm_min())); EXPECT_EQ(-0.0, Common::FlushToZero(-std::numeric_limits<double>::denorm_min()));