The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-02-10 14:39:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

Common/SymbolDB: Use std::string_view where applicable

Browse Source 
These strings are only used for comparison against other strings, so a
string view can be used here.
This commit is contained in:
Lioncash 2019-06-16 01:09:58 -04:00
parent 9cf6ba13df
commit 936aa5dbaa
No known key found for this signature in database
GPG Key ID: 4E3C3CC1031BA9C7
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/Common/SymbolDB.cpp
View File

@ -63,7 +63,7 @@ void SymbolDB::Index()
} }
} }
Symbol* SymbolDB::GetSymbolFromName(const std::string& name) Symbol* SymbolDB::GetSymbolFromName(std::string_view name)
{ {
for (auto& func : m_functions) for (auto& func : m_functions)
{ {
@ -74,7 +74,7 @@ Symbol* SymbolDB::GetSymbolFromName(const std::string& name)
return nullptr; return nullptr;
} }
std::vector<Symbol*> SymbolDB::GetSymbolsFromName(const std::string& name) std::vector<Symbol*> SymbolDB::GetSymbolsFromName(std::string_view name)
{ {
std::vector<Symbol*> symbols; std::vector<Symbol*> symbols;

5
Source/Core/Common/SymbolDB.h
View File

@ -10,6 +10,7 @@
#include <map> #include <map>
#include <set> #include <set>
#include <string> #include <string>
#include <string_view>
#include <utility> #include <utility>
#include <vector> #include <vector>
@ -71,8 +72,8 @@ public:
virtual Symbol* AddFunction(u32 start_addr) { return nullptr; } virtual Symbol* AddFunction(u32 start_addr) { return nullptr; }
void AddCompleteSymbol(const Symbol& symbol); void AddCompleteSymbol(const Symbol& symbol);
Symbol* GetSymbolFromName(const std::string& name); Symbol* GetSymbolFromName(std::string_view name);
std::vector<Symbol*> GetSymbolsFromName(const std::string& name); std::vector<Symbol*> GetSymbolsFromName(std::string_view name);
Symbol* GetSymbolFromHash(u32 hash); Symbol* GetSymbolFromHash(u32 hash);
std::vector<Symbol*> GetSymbolsFromHash(u32 hash); std::vector<Symbol*> GetSymbolsFromHash(u32 hash);