From b8f4a4ae449307f8cd86c4db16085a03ed255a9e Mon Sep 17 00:00:00 2001 From: Pokechu22 Date: Tue, 14 Sep 2021 10:47:35 -0700 Subject: [PATCH] GLInterface: Remove unneeded wglShareLists call When RenderDoc is attached, wglShareLists fails for some reason (see baldurk/renderdoc#2361). wglCreateContextAttribsARB has a parameter for the share context, so there's no reason to use a separate wglShareLists call. Co-authored-by: baldurk --- Source/Core/Common/GL/GLInterface/WGL.cpp | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/Source/Core/Common/GL/GLInterface/WGL.cpp b/Source/Core/Common/GL/GLInterface/WGL.cpp index 69d9e93912..d0d343be01 100644 --- a/Source/Core/Common/GL/GLInterface/WGL.cpp +++ b/Source/Core/Common/GL/GLInterface/WGL.cpp @@ -396,20 +396,9 @@ HGLRC GLContextWGL::CreateCoreContext(HDC dc, HGLRC share_context) 0}; // Attempt creating this context. - HGLRC core_context = wglCreateContextAttribsARB(dc, nullptr, attribs.data()); + HGLRC core_context = wglCreateContextAttribsARB(dc, share_context, attribs.data()); if (core_context) { - // If we're creating a shared context, share the resources before the context is used. - if (share_context) - { - if (!wglShareLists(share_context, core_context)) - { - ERROR_LOG_FMT(VIDEO, "wglShareLists failed"); - wglDeleteContext(core_context); - return nullptr; - } - } - INFO_LOG_FMT(VIDEO, "WGL: Created a GL {}.{} core context", version.first, version.second); return core_context; }