The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-01-10 08:09:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

DSPHLE: Properly reflect initial halt state in mail handler

Browse Source 
DSPHLE::Initialize sets the halt and init bits to true (i.e. m_dsp_control.Hex starts as 0x804), which is reasonable behavior (this is the state the DSP will be in when starting a game from the IPL, as after `__OSStopAudioSystem` the control register is 0x804).
However, CMailHandler::m_halted defaults to false, and we only call CMailHandler::SetHalted in DSPHLE::DSP_WriteControlRegister when m_dsp_control.DSPHalt changes, so since DSPHalt defaults to true, if the first thing that happens is writing true to DSPHalt, we won't properly halt the mail handler.
Now, we call CMailHandler::SetHalted on startup. This fixes Datel titles when the IPL is skipped with DSP HLE (though this configuration only works once https://bugs.dolphin-emu.org/issues/8223 is fixed).
This commit is contained in:
Pokechu22 2022-06-25 14:06:55 -07:00
parent b30e1c5bb9
commit 9675faa232
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Source/Core/Core/HW/DSPHLE/DSPHLE.cpp
View File

@ -28,6 +28,7 @@ bool DSPHLE::Initialize(bool wii, bool dsp_thread)
m_dsp_control.Hex = 0;
m_dsp_control.DSPHalt = 1;
m_dsp_control.DSPInit = 1;
m_mail_handler.SetHalted(m_dsp_control.DSPHalt);
m_dsp_state.Reset();