From 2999cca41bf8ccb9442c37ef073b12aed4d99316 Mon Sep 17 00:00:00 2001 From: Dentomologist Date: Fri, 3 Jun 2022 20:56:06 -0700 Subject: [PATCH 1/2] UnitTests: Fix -Wrange-loop-construct warnings Don't use reference variable bound to a temporary value --- Source/UnitTests/Core/IOS/FS/FileSystemTest.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/UnitTests/Core/IOS/FS/FileSystemTest.cpp b/Source/UnitTests/Core/IOS/FS/FileSystemTest.cpp index 15d3544f1d..5442a66eab 100644 --- a/Source/UnitTests/Core/IOS/FS/FileSystemTest.cpp +++ b/Source/UnitTests/Core/IOS/FS/FileSystemTest.cpp @@ -93,7 +93,7 @@ TEST(FileSystem, PathSplitting) TEST_F(FileSystemTest, EssentialDirectories) { - for (const std::string& path : + for (const std::string path : {"/sys", "/ticket", "/title", "/shared1", "/shared2", "/tmp", "/import", "/meta"}) { EXPECT_TRUE(m_fs->ReadDirectory(Uid{0}, Gid{0}, path).Succeeded()) << path; @@ -457,7 +457,7 @@ TEST_F(FileSystemTest, CreateFullPath) ASSERT_EQ(m_fs->CreateFullPath(Uid{0}, Gid{0}, "/tmp/a/b/c/d", 0, modes), ResultCode::Success); // Parent directories should be created by CreateFullPath. - for (const std::string& path : {"/tmp", "/tmp/a", "/tmp/a/b", "/tmp/a/b/c"}) + for (const std::string path : {"/tmp", "/tmp/a", "/tmp/a/b", "/tmp/a/b/c"}) EXPECT_TRUE(m_fs->ReadDirectory(Uid{0}, Gid{0}, path).Succeeded()); // If parent directories already exist, the call should still succeed. From 92af703f2914fbdee14ee7b78e624a82de1145e7 Mon Sep 17 00:00:00 2001 From: Dentomologist Date: Fri, 3 Jun 2022 22:18:54 -0700 Subject: [PATCH 2/2] DSPAssembler: Fix -Wswitch warning --- Source/Core/Core/DSP/DSPAssembler.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Source/Core/Core/DSP/DSPAssembler.cpp b/Source/Core/Core/DSP/DSPAssembler.cpp index ed181b7a3c..fccbfd84d6 100644 --- a/Source/Core/Core/DSP/DSPAssembler.cpp +++ b/Source/Core/Core/DSP/DSPAssembler.cpp @@ -584,7 +584,6 @@ bool DSPAssembler::VerifyParams(const DSPOPCTemplate* opc, param_t* par, size_t } } break; - case P_ACCL: if ((int)par[i].val < DSP_REG_ACL0 || (int)par[i].val > DSP_REG_ACL1) { @@ -602,6 +601,8 @@ bool DSPAssembler::VerifyParams(const DSPOPCTemplate* opc, param_t* par, size_t } } break; + default: + break; } continue; }