From 9911e51c8f409a6301c7c140c6b67fb4c2cd59bd Mon Sep 17 00:00:00 2001 From: Lioncash Date: Fri, 18 May 2018 13:33:19 -0400 Subject: [PATCH] Interpreter_Branch: Make type of the bitmask in rfi a u32 instead of int Given this is a bitmask, we should be using an unsigned type to store it (especially given it's outside the range an int can represent properly without being considered negative). No behavior change is caused by this, it just silences a sign conversion warning. --- Source/Core/Core/PowerPC/Interpreter/Interpreter_Branch.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/Core/PowerPC/Interpreter/Interpreter_Branch.cpp b/Source/Core/Core/PowerPC/Interpreter/Interpreter_Branch.cpp index a9bbbe7bf4..22815f1993 100644 --- a/Source/Core/Core/PowerPC/Interpreter/Interpreter_Branch.cpp +++ b/Source/Core/Core/PowerPC/Interpreter/Interpreter_Branch.cpp @@ -121,7 +121,7 @@ void Interpreter::rfi(UGeckoInstruction inst) { // Restore saved bits from SRR1 to MSR. // Gecko/Broadway can save more bits than explicitly defined in ppc spec - const int mask = 0x87C0FFFF; + const u32 mask = 0x87C0FFFF; MSR.Hex = (MSR.Hex & ~mask) | (SRR1 & mask); // MSR[13] is set to 0. MSR.Hex &= 0xFFFBFFFF;