The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-01-27 08:15:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

DSPHWInterface: Use an enum for indicating mailbox type

Browse Source
This commit is contained in:
Lioncash 2015-10-03 16:54:40 -04:00
parent 5464e698fc
commit 9c73d63d40
3 changed files with 40 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
Source/Core/Core/DSP/DSPHWInterface.cpp
View File

@ -26,16 +26,16 @@ void gdsp_ifx_init()
g_dsp.ifx_regs[i] = 0; g_dsp.ifx_regs[i] = 0;
} }
g_dsp.mbox[0].store(0); g_dsp.mbox[MAILBOX_CPU].store(0);
g_dsp.mbox[1].store(0); g_dsp.mbox[MAILBOX_DSP].store(0);
} }
u32 gdsp_mbox_peek(u8 mbx) u32 gdsp_mbox_peek(Mailbox mbx)
{ {
return g_dsp.mbox[mbx].load(); return g_dsp.mbox[mbx].load();
} }
void gdsp_mbox_write_h(u8 mbx, u16 val) void gdsp_mbox_write_h(Mailbox mbx, u16 val)
{ {
const u32 old_value = g_dsp.mbox[mbx].load(std::memory_order_acquire); const u32 old_value = g_dsp.mbox[mbx].load(std::memory_order_acquire);
const u32 new_value = (old_value & 0xffff) | (val << 16); const u32 new_value = (old_value & 0xffff) | (val << 16);
@ -43,7 +43,7 @@ void gdsp_mbox_write_h(u8 mbx, u16 val)
g_dsp.mbox[mbx].store(new_value & ~0x80000000, std::memory_order_release); g_dsp.mbox[mbx].store(new_value & ~0x80000000, std::memory_order_release);
} }
void gdsp_mbox_write_l(u8 mbx, u16 val) void gdsp_mbox_write_l(Mailbox mbx, u16 val)
{ {
const u32 old_value = g_dsp.mbox[mbx].load(std::memory_order_acquire); const u32 old_value = g_dsp.mbox[mbx].load(std::memory_order_acquire);
const u32 new_value = (old_value & ~0xffff) | val; const u32 new_value = (old_value & ~0xffff) | val;
@ -51,18 +51,16 @@ void gdsp_mbox_write_l(u8 mbx, u16 val)
g_dsp.mbox[mbx].store(new_value | 0x80000000, std::memory_order_release); g_dsp.mbox[mbx].store(new_value | 0x80000000, std::memory_order_release);
#if defined(_DEBUG) || defined(DEBUGFAST) #if defined(_DEBUG) || defined(DEBUGFAST)
if (mbx == GDSP_MBOX_DSP) if (mbx == MAILBOX_DSP)
{ INFO_LOG(DSP_MAIL, "DSP(WM) B:%i M:0x%08x (pc=0x%04x)", mbx, gdsp_mbox_peek(MAILBOX_DSP), g_dsp.pc);
INFO_LOG(DSP_MAIL, "DSP(WM) B:%i M:0x%08x (pc=0x%04x)", mbx, gdsp_mbox_peek(GDSP_MBOX_DSP), g_dsp.pc); else
} else { INFO_LOG(DSP_MAIL, "CPU(WM) B:%i M:0x%08x (pc=0x%04x)", mbx, gdsp_mbox_peek(MAILBOX_CPU), g_dsp.pc);
INFO_LOG(DSP_MAIL, "CPU(WM) B:%i M:0x%08x (pc=0x%04x)", mbx, gdsp_mbox_peek(GDSP_MBOX_CPU), g_dsp.pc);
}
#endif #endif
} }
u16 gdsp_mbox_read_h(u8 mbx) u16 gdsp_mbox_read_h(Mailbox mbx)
{ {
if (init_hax && mbx) if (init_hax && mbx == MAILBOX_DSP)
{ {
return 0x8054; return 0x8054;
} }
@ -70,12 +68,12 @@ u16 gdsp_mbox_read_h(u8 mbx)
return (u16)(g_dsp.mbox[mbx].load() >> 16); // TODO: mask away the top bit? return (u16)(g_dsp.mbox[mbx].load() >> 16); // TODO: mask away the top bit?
} }
u16 gdsp_mbox_read_l(u8 mbx) u16 gdsp_mbox_read_l(Mailbox mbx)
{ {
const u32 value = g_dsp.mbox[mbx].load(std::memory_order_acquire); const u32 value = g_dsp.mbox[mbx].load(std::memory_order_acquire);
g_dsp.mbox[mbx].store(value & ~0x80000000, std::memory_order_release); g_dsp.mbox[mbx].store(value & ~0x80000000, std::memory_order_release);
if (init_hax && mbx) if (init_hax && mbx == MAILBOX_DSP)
{ {
init_hax = false; init_hax = false;
DSPCore_Reset(); DSPCore_Reset();
@ -83,12 +81,10 @@ u16 gdsp_mbox_read_l(u8 mbx)
} }
#if defined(_DEBUG) || defined(DEBUGFAST) #if defined(_DEBUG) || defined(DEBUGFAST)
if (mbx == GDSP_MBOX_DSP) if (mbx == MAILBOX_DSP)
{ INFO_LOG(DSP_MAIL, "DSP(RM) B:%i M:0x%08x (pc=0x%04x)", mbx, gdsp_mbox_peek(MAILBOX_DSP), g_dsp.pc);
INFO_LOG(DSP_MAIL, "DSP(RM) B:%i M:0x%08x (pc=0x%04x)", mbx, gdsp_mbox_peek(GDSP_MBOX_DSP), g_dsp.pc); else
} else { INFO_LOG(DSP_MAIL, "CPU(RM) B:%i M:0x%08x (pc=0x%04x)", mbx, gdsp_mbox_peek(MAILBOX_CPU), g_dsp.pc);
INFO_LOG(DSP_MAIL, "CPU(RM) B:%i M:0x%08x (pc=0x%04x)", mbx, gdsp_mbox_peek(GDSP_MBOX_CPU), g_dsp.pc);
}
#endif #endif
return (u16)value; return (u16)value;
@ -108,18 +104,18 @@ void gdsp_ifx_write(u32 addr, u32 val)
break; break;
case DSP_DMBH: case DSP_DMBH:
gdsp_mbox_write_h(GDSP_MBOX_DSP, val); gdsp_mbox_write_h(MAILBOX_DSP, val);
break; break;
case DSP_DMBL: case DSP_DMBL:
gdsp_mbox_write_l(GDSP_MBOX_DSP, val); gdsp_mbox_write_l(MAILBOX_DSP, val);
break; break;
case DSP_CMBH: case DSP_CMBH:
return gdsp_mbox_write_h(GDSP_MBOX_CPU, val); return gdsp_mbox_write_h(MAILBOX_CPU, val);
case DSP_CMBL: case DSP_CMBL:
return gdsp_mbox_write_l(GDSP_MBOX_CPU, val); return gdsp_mbox_write_l(MAILBOX_CPU, val);
case DSP_DSBL: case DSP_DSBL:
g_dsp.ifx_regs[DSP_DSBL] = val; g_dsp.ifx_regs[DSP_DSBL] = val;
@ -178,16 +174,16 @@ static u16 _gdsp_ifx_read(u16 addr)
switch (addr & 0xff) switch (addr & 0xff)
{ {
case DSP_DMBH: case DSP_DMBH:
return gdsp_mbox_read_h(GDSP_MBOX_DSP); return gdsp_mbox_read_h(MAILBOX_DSP);
case DSP_DMBL: case DSP_DMBL:
return gdsp_mbox_read_l(GDSP_MBOX_DSP); return gdsp_mbox_read_l(MAILBOX_DSP);
case DSP_CMBH: case DSP_CMBH:
return gdsp_mbox_read_h(GDSP_MBOX_CPU); return gdsp_mbox_read_h(MAILBOX_CPU);
case DSP_CMBL: case DSP_CMBL:
return gdsp_mbox_read_l(GDSP_MBOX_CPU); return gdsp_mbox_read_l(MAILBOX_CPU);
case DSP_DSCR: case DSP_DSCR:
return g_dsp.ifx_regs[addr & 0xFF]; return g_dsp.ifx_regs[addr & 0xFF];

18
Source/Core/Core/DSP/DSPHWInterface.h
View File

@ -7,16 +7,18 @@
#include "Common/CommonTypes.h" #include "Common/CommonTypes.h"
#define GDSP_MBOX_CPU 0 enum Mailbox
#define GDSP_MBOX_DSP 1 {
MAILBOX_CPU,
MAILBOX_DSP
};
u32 gdsp_mbox_peek(u8 mbx); u32 gdsp_mbox_peek(Mailbox mbx);
void gdsp_mbox_write_h(u8 mbx, u16 val); void gdsp_mbox_write_h(Mailbox mbx, u16 val);
void gdsp_mbox_write_l(u8 mbx, u16 val); void gdsp_mbox_write_l(Mailbox mbx, u16 val);
u16 gdsp_mbox_read_h(u8 mbx); u16 gdsp_mbox_read_h(Mailbox mbx);
u16 gdsp_mbox_read_l(u8 mbx); u16 gdsp_mbox_read_l(Mailbox mbx);
void gdsp_ifx_init(); void gdsp_ifx_init();
void gdsp_ifx_write(u32 addr, u32 val); void gdsp_ifx_write(u32 addr, u32 val);
u16 gdsp_ifx_read(u16 addr); u16 gdsp_ifx_read(u16 addr);

10
Source/Core/Core/HW/DSPLLE/DSPLLE.cpp
View File

@ -249,19 +249,19 @@ u16 DSPLLE::DSP_ReadControlRegister()
u16 DSPLLE::DSP_ReadMailBoxHigh(bool _CPUMailbox) u16 DSPLLE::DSP_ReadMailBoxHigh(bool _CPUMailbox)
{ {
return gdsp_mbox_read_h(_CPUMailbox ? GDSP_MBOX_CPU : GDSP_MBOX_DSP); return gdsp_mbox_read_h(_CPUMailbox ? MAILBOX_CPU : MAILBOX_DSP);
} }
u16 DSPLLE::DSP_ReadMailBoxLow(bool _CPUMailbox) u16 DSPLLE::DSP_ReadMailBoxLow(bool _CPUMailbox)
{ {
return gdsp_mbox_read_l(_CPUMailbox ? GDSP_MBOX_CPU : GDSP_MBOX_DSP); return gdsp_mbox_read_l(_CPUMailbox ? MAILBOX_CPU : MAILBOX_DSP);
} }
void DSPLLE::DSP_WriteMailBoxHigh(bool _CPUMailbox, u16 _uHighMail) void DSPLLE::DSP_WriteMailBoxHigh(bool _CPUMailbox, u16 _uHighMail)
{ {
if (_CPUMailbox) if (_CPUMailbox)
{ {
if (gdsp_mbox_peek(GDSP_MBOX_CPU) & 0x80000000) if (gdsp_mbox_peek(MAILBOX_CPU) & 0x80000000)
{ {
ERROR_LOG(DSPLLE, "Mailbox isnt empty ... strange"); ERROR_LOG(DSPLLE, "Mailbox isnt empty ... strange");
} }
@ -273,7 +273,7 @@ void DSPLLE::DSP_WriteMailBoxHigh(bool _CPUMailbox, u16 _uHighMail)
} }
#endif #endif
gdsp_mbox_write_h(GDSP_MBOX_CPU, _uHighMail); gdsp_mbox_write_h(MAILBOX_CPU, _uHighMail);
} }
else else
{ {
@ -285,7 +285,7 @@ void DSPLLE::DSP_WriteMailBoxLow(bool _CPUMailbox, u16 _uLowMail)
{ {
if (_CPUMailbox) if (_CPUMailbox)
{ {
gdsp_mbox_write_l(GDSP_MBOX_CPU, _uLowMail); gdsp_mbox_write_l(MAILBOX_CPU, _uLowMail);
} }
else else
{ {