From 9eab3feddf0b3457cfe933532e0ed51834c6bb02 Mon Sep 17 00:00:00 2001 From: Silent Date: Sun, 23 Jun 2019 20:06:45 +0200 Subject: [PATCH] Fix out of bounds read in HttpRequest::Impl::Fetch logging --- Source/Core/Common/HttpRequest.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Core/Common/HttpRequest.cpp b/Source/Core/Common/HttpRequest.cpp index b26a120b32..34ab47a095 100644 --- a/Source/Core/Common/HttpRequest.cpp +++ b/Source/Core/Common/HttpRequest.cpp @@ -221,8 +221,8 @@ HttpRequest::Response HttpRequest::Impl::Fetch(const std::string& url, Method me curl_easy_getinfo(m_curl.get(), CURLINFO_RESPONSE_CODE, &response_code); if (response_code != 200) { - ERROR_LOG(COMMON, "Failed to %s %s: server replied with code %li and body\n\x1b[0m%s", type, - url.c_str(), response_code, buffer.data()); + ERROR_LOG(COMMON, "Failed to %s %s: server replied with code %li and body\n\x1b[0m%.*s", type, + url.c_str(), response_code, static_cast(buffer.size()), buffer.data()); return {}; }