The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-06-11 16:49:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

Pass strings by const reference where possible

Browse Source
This commit is contained in:
Lioncash
2015-05-28 20:28:48 -04:00
parent 6ff3fcee59
commit ac26f8e79f
21 changed files with 32 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/InputCommon/ControllerInterface/ExpressionParser.cpp
View File

@ -92,7 +92,7 @@ public:
std::string expr;
std::string::iterator it;
Lexer(std::string expr_) : expr(expr_)
Lexer(const std::string& expr_) : expr(expr_)
{
it = expr.begin();
}
@ -568,7 +568,7 @@ Expression::~Expression()
delete node;
}
static ExpressionParseStatus ParseExpressionInner(std::string str, ControlFinder &finder, Expression **expr_out)
static ExpressionParseStatus ParseExpressionInner(const std::string& str, ControlFinder &finder, Expression **expr_out)
{
ExpressionParseStatus status;
Expression *expr;
@ -592,7 +592,7 @@ static ExpressionParseStatus ParseExpressionInner(std::string str, ControlFinder
return EXPRESSION_PARSE_SUCCESS;
}
ExpressionParseStatus ParseExpression(std::string str, ControlFinder &finder, Expression **expr_out)
ExpressionParseStatus ParseExpression(const std::string& str, ControlFinder &finder, Expression **expr_out)
{
// Add compatibility with old simple expressions, which are simple
// barewords control names.