From b3c5021fc47dc25bf7477df89ce28cf7f217572d Mon Sep 17 00:00:00 2001 From: Dentomologist Date: Sat, 1 Jul 2023 18:06:08 -0700 Subject: [PATCH] GekkoDisassembler: Remove unused parameter dmode from rrn function With the removal of m_flags, dmode is no longer used in rrn. --- Source/Core/Common/GekkoDisassembler.cpp | 9 ++++----- Source/Core/Common/GekkoDisassembler.h | 3 +-- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/Source/Core/Common/GekkoDisassembler.cpp b/Source/Core/Common/GekkoDisassembler.cpp index b572dc767e..f068ea9628 100644 --- a/Source/Core/Common/GekkoDisassembler.cpp +++ b/Source/Core/Common/GekkoDisassembler.cpp @@ -733,8 +733,7 @@ void GekkoDisassembler::dab(u32 in, std::string_view name, int mask, int smode, } // Last operand is no register: xxxx rD,rA,NB -void GekkoDisassembler::rrn(u32 in, std::string_view name, int smode, int chkoe, int chkrc, - unsigned char dmode) +void GekkoDisassembler::rrn(u32 in, std::string_view name, int smode, int chkoe, int chkrc) { if (chkrc >= 0 && ((in & 1) != (unsigned int)chkrc)) { @@ -1880,7 +1879,7 @@ u32* GekkoDisassembler::DoDisassembly(bool big_endian) break; case 597: - rrn(in, "lswi", 0, 0, 0, 0); + rrn(in, "lswi", 0, 0, 0); break; case 598: @@ -1919,7 +1918,7 @@ u32* GekkoDisassembler::DoDisassembly(bool big_endian) break; case 725: - rrn(in, "stswi", 0, 0, 0, 0); + rrn(in, "stswi", 0, 0, 0); break; case 727: @@ -1943,7 +1942,7 @@ u32* GekkoDisassembler::DoDisassembly(bool big_endian) break; case 824: - rrn(in, "srawi", 1, 0, -1, 0); + rrn(in, "srawi", 1, 0, -1); break; case 854: diff --git a/Source/Core/Common/GekkoDisassembler.h b/Source/Core/Common/GekkoDisassembler.h index 8f842b0167..9a276a4d7e 100644 --- a/Source/Core/Common/GekkoDisassembler.h +++ b/Source/Core/Common/GekkoDisassembler.h @@ -73,8 +73,7 @@ private: static void cmp(u32 in); static void trap(u32 in, unsigned char dmode); static void dab(u32 in, std::string_view name, int mask, int smode, int chkoe, int chkrc); - static void rrn(u32 in, std::string_view name, int smode, int chkoe, int chkrc, - unsigned char dmode); + static void rrn(u32 in, std::string_view name, int smode, int chkoe, int chkrc); static void mtcr(u32 in); static void msr(u32 in, int smode); static void mspr(u32 in, int smode);