The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-01-10 08:09:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

UICommon/GameFile: Make COVER_URL a plain C string

Browse Source 
Same behavior but doesn't take up 8 bytes in the executable to store a
pointer. While we're at it, move it into an anonymous namespace within
the UICommon namespace.
This commit is contained in:
Lioncash 2019-05-28 07:18:10 -04:00
parent 8229ada922
commit b4470ad4c2
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Source/Core/UICommon/GameFile.cpp
View File

@ -39,13 +39,15 @@
#include "DiscIO/Volume.h" #include "DiscIO/Volume.h"
#include "DiscIO/WiiSaveBanner.h" #include "DiscIO/WiiSaveBanner.h"
constexpr const char* COVER_URL = "https://art.gametdb.com/wii/cover/%s/%s.png";
namespace UICommon namespace UICommon
{ {
static const std::string EMPTY_STRING; namespace
{
constexpr char COVER_URL[] = "https://art.gametdb.com/wii/cover/%s/%s.png";
static bool UseGameCovers() const std::string EMPTY_STRING;
bool UseGameCovers()
{ {
// We ifdef this out on Android because accessing the config before emulation start makes us crash. // We ifdef this out on Android because accessing the config before emulation start makes us crash.
// The Android GUI handles covers in Java anyway, so this doesn't make us lose any functionality. // The Android GUI handles covers in Java anyway, so this doesn't make us lose any functionality.
@ -55,6 +57,7 @@ static bool UseGameCovers()
return Config::Get(Config::MAIN_USE_GAME_COVERS); return Config::Get(Config::MAIN_USE_GAME_COVERS);
#endif #endif
} }
} // Anonymous namespace
DiscIO::Language GameFile::GetConfigLanguage() const DiscIO::Language GameFile::GetConfigLanguage() const
{ {