The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-02-03 19:42:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

Jit64: Extract handling of immediate Rc

Browse Source
This commit is contained in:
JosJuice 2023-08-22 18:49:28 +02:00
parent c528a70e64
commit be8e3fc5ae
2 changed files with 22 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Source/Core/Core/PowerPC/Jit64/Jit.h
View File

@ -120,6 +120,7 @@ public:
void FinalizeCarry(Gen::CCFlags cond); void FinalizeCarry(Gen::CCFlags cond);
void FinalizeCarry(bool ca); void FinalizeCarry(bool ca);
void ComputeRC(preg_t preg, bool needs_test = true, bool needs_sext = true); void ComputeRC(preg_t preg, bool needs_test = true, bool needs_sext = true);
void FinalizeImmediateRC(s32 value);
void AndWithMask(Gen::X64Reg reg, u32 mask); void AndWithMask(Gen::X64Reg reg, u32 mask);
void RotateLeft(int bits, Gen::X64Reg regOp, const Gen::OpArg& arg, u8 rotate); void RotateLeft(int bits, Gen::X64Reg regOp, const Gen::OpArg& arg, u8 rotate);

40
Source/Core/Core/PowerPC/Jit64/Jit_Integer.cpp
View File

@ -150,7 +150,10 @@ void Jit64::ComputeRC(preg_t preg, bool needs_test, bool needs_sext)
if (arg.IsImm()) if (arg.IsImm())
{ {
MOV(64, PPCSTATE_CR(0), Imm32(arg.SImm32())); const s32 value = arg.SImm32();
arg.Unlock();
FinalizeImmediateRC(value);
return;
} }
else if (needs_sext) else if (needs_sext)
{ {
@ -164,33 +167,32 @@ void Jit64::ComputeRC(preg_t preg, bool needs_test, bool needs_sext)
if (CheckMergedBranch(0)) if (CheckMergedBranch(0))
{ {
if (arg.IsImm()) if (needs_test)
{ {
s32 offset = arg.SImm32(); TEST(32, arg, arg);
arg.Unlock(); arg.Unlock();
DoMergedBranchImmediate(offset);
} }
else else
{ {
if (needs_test) // If an operand to the cmp/rc op we're merging with the branch isn't used anymore, it'd be
{ // better to flush it here so that we don't have to flush it on both sides of the branch.
TEST(32, arg, arg); // We don't want to do this if a test is needed though, because it would interrupt macro-op
arg.Unlock(); // fusion.
} arg.Unlock();
else gpr.Flush(~js.op->gprInUse);
{
// If an operand to the cmp/rc op we're merging with the branch isn't used anymore, it'd be
// better to flush it here so that we don't have to flush it on both sides of the branch.
// We don't want to do this if a test is needed though, because it would interrupt macro-op
// fusion.
arg.Unlock();
gpr.Flush(~js.op->gprInUse);
}
DoMergedBranchCondition();
} }
DoMergedBranchCondition();
} }
} }
void Jit64::FinalizeImmediateRC(s32 value)
{
MOV(64, PPCSTATE_CR(0), Imm32(value));
if (CheckMergedBranch(0))
DoMergedBranchImmediate(value);
}
// we can't do this optimization in the emitter because MOVZX and AND have different effects on // we can't do this optimization in the emitter because MOVZX and AND have different effects on
// flags. // flags.
void Jit64::AndWithMask(X64Reg reg, u32 mask) void Jit64::AndWithMask(X64Reg reg, u32 mask)