From c657b8099629eff7eebd73269ce2e168807e7b97 Mon Sep 17 00:00:00 2001 From: Pokechu22 Date: Tue, 8 Mar 2022 13:59:55 -0800 Subject: [PATCH] Software/EfbInterface: Remove logspam for RGB565_Z16 being unsupported This message would be logged, usually multiple times, for EVERY. SINGLE. PIXEL. That's pretty much useless and just makes the log unreadable. Plus, the current support (which acts as RGB8) is close enough that for end-user purposes, it's fine. I don't think the hardware backends support RGB565_Z16 and its antialiasing functionality correctly either, but they don't have similar logspam. --- Source/Core/VideoBackends/Software/EfbInterface.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Source/Core/VideoBackends/Software/EfbInterface.cpp b/Source/Core/VideoBackends/Software/EfbInterface.cpp index 70d5c66e80..1e5498e28a 100644 --- a/Source/Core/VideoBackends/Software/EfbInterface.cpp +++ b/Source/Core/VideoBackends/Software/EfbInterface.cpp @@ -87,7 +87,7 @@ static void SetPixelColorOnly(u32 offset, u8* rgb) break; case PixelFormat::RGB565_Z16: { - INFO_LOG_FMT(VIDEO, "RGB565_Z16 is not supported correctly yet"); + // TODO: RGB565_Z16 is not supported correctly yet u32 src = *(u32*)rgb; u32* dst = (u32*)&efb[offset]; u32 val = *dst & 0xff000000; @@ -129,7 +129,7 @@ static void SetPixelAlphaColor(u32 offset, u8* color) break; case PixelFormat::RGB565_Z16: { - INFO_LOG_FMT(VIDEO, "RGB565_Z16 is not supported correctly yet"); + // TODO: RGB565_Z16 is not supported correctly yet u32 src = *(u32*)color; u32* dst = (u32*)&efb[offset]; u32 val = *dst & 0xff000000; @@ -161,7 +161,7 @@ static u32 GetPixelColor(u32 offset) Convert6To8((src >> 18) & 0x3f) << 24; // Red case PixelFormat::RGB565_Z16: - INFO_LOG_FMT(VIDEO, "RGB565_Z16 is not supported correctly yet"); + // TODO: RGB565_Z16 is not supported correctly yet return 0xff | ((src & 0x00ffffff) << 8); default: @@ -186,7 +186,7 @@ static void SetPixelDepth(u32 offset, u32 depth) break; case PixelFormat::RGB565_Z16: { - INFO_LOG_FMT(VIDEO, "RGB565_Z16 is not supported correctly yet"); + // TODO: RGB565_Z16 is not supported correctly yet u32* dst = (u32*)&efb[offset]; u32 val = *dst & 0xff000000; val |= depth & 0x00ffffff; @@ -214,7 +214,7 @@ static u32 GetPixelDepth(u32 offset) break; case PixelFormat::RGB565_Z16: { - INFO_LOG_FMT(VIDEO, "RGB565_Z16 is not supported correctly yet"); + // TODO: RGB565_Z16 is not supported correctly yet depth = (*(u32*)&efb[offset]) & 0x00ffffff; } break;