From c958fc1278f90b8fb4e401abc9a7a16f76f42401 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 29 May 2019 06:18:55 -0400 Subject: [PATCH] VideoCommon/NetPlayChatUI: Default destructor in the cpp file Ensures that the destruction logic is kept local to the translation unit (making it nicer when it comes to forward declaring non-trivial types). It also doesn't really do much to define it in the header. --- Source/Core/VideoCommon/NetPlayChatUI.cpp | 2 ++ Source/Core/VideoCommon/NetPlayChatUI.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Source/Core/VideoCommon/NetPlayChatUI.cpp b/Source/Core/VideoCommon/NetPlayChatUI.cpp index 7428233286..a84c26d8d7 100644 --- a/Source/Core/VideoCommon/NetPlayChatUI.cpp +++ b/Source/Core/VideoCommon/NetPlayChatUI.cpp @@ -18,6 +18,8 @@ NetPlayChatUI::NetPlayChatUI(std::function callback) { } +NetPlayChatUI::~NetPlayChatUI() = default; + void NetPlayChatUI::Display() { const float scale = ImGui::GetIO().DisplayFramebufferScale.x; diff --git a/Source/Core/VideoCommon/NetPlayChatUI.h b/Source/Core/VideoCommon/NetPlayChatUI.h index 8ec13a770d..c995db5c50 100644 --- a/Source/Core/VideoCommon/NetPlayChatUI.h +++ b/Source/Core/VideoCommon/NetPlayChatUI.h @@ -15,7 +15,7 @@ class NetPlayChatUI { public: explicit NetPlayChatUI(std::function callback); - ~NetPlayChatUI() = default; + ~NetPlayChatUI(); using Color = std::array;