From f7c9d2fd4d352badd46d0b1459ea934fba295dff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9o=20Lam?= Date: Sat, 24 Mar 2018 17:50:47 +0100 Subject: [PATCH 1/5] Qt: Show code pane by default in debug mode Otherwise, it's confusing because the option seems to do nothing especially if the user is used to the DolphinWX debugger. --- Source/Core/DolphinQt2/Settings.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Source/Core/DolphinQt2/Settings.cpp b/Source/Core/DolphinQt2/Settings.cpp index baa86879e8..6b51777b7c 100644 --- a/Source/Core/DolphinQt2/Settings.cpp +++ b/Source/Core/DolphinQt2/Settings.cpp @@ -226,6 +226,8 @@ void Settings::SetDebugModeEnabled(bool enabled) SConfig::GetInstance().bEnableDebugging = enabled; emit DebugModeToggled(enabled); } + if (enabled) + SetCodeVisible(true); } bool Settings::IsDebugModeEnabled() const From 8d0c15bb974050db966407e2d9e77ec824f4c1e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9o=20Lam?= Date: Sat, 24 Mar 2018 18:02:17 +0100 Subject: [PATCH 2/5] Qt/Search: Simplify placeholder text A search box is a common UI element. We don't need to explicitly tell the user that they need to type a search term. Also, Let's use the common "Search ..." placeholder text instead and make the string shorter for localisation. --- Source/Core/DolphinQt2/SearchBar.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/DolphinQt2/SearchBar.cpp b/Source/Core/DolphinQt2/SearchBar.cpp index d4ccb8638e..27ed057f52 100644 --- a/Source/Core/DolphinQt2/SearchBar.cpp +++ b/Source/Core/DolphinQt2/SearchBar.cpp @@ -24,7 +24,7 @@ void SearchBar::CreateWidgets() m_search_edit = new QLineEdit; m_close_button = new QPushButton(tr("Close")); - m_search_edit->setPlaceholderText(tr("Type your search term here")); + m_search_edit->setPlaceholderText(tr("Search games...")); auto* layout = new QHBoxLayout; From 752098de22173e72daa2aceac22a84d38effc01c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9o=20Lam?= Date: Sat, 24 Mar 2018 18:08:34 +0100 Subject: [PATCH 3/5] Qt: Fix search bar widget spacing With setMargin(0), the widgets look awkwardly close to the window edges --- Source/Core/DolphinQt2/SearchBar.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/DolphinQt2/SearchBar.cpp b/Source/Core/DolphinQt2/SearchBar.cpp index 27ed057f52..71b38bf92f 100644 --- a/Source/Core/DolphinQt2/SearchBar.cpp +++ b/Source/Core/DolphinQt2/SearchBar.cpp @@ -30,7 +30,7 @@ void SearchBar::CreateWidgets() layout->addWidget(m_search_edit); layout->addWidget(m_close_button); - layout->setMargin(0); + layout->setSizeConstraint(QLayout::SetMinAndMaxSize); setLayout(layout); } From bf05c74f6b9e360fff3a86e596f6ee0cb9dc0554 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9o=20Lam?= Date: Sat, 24 Mar 2018 18:18:17 +0100 Subject: [PATCH 4/5] Qt: Fix GameCube config pane spacing --- Source/Core/DolphinQt2/Settings/GameCubePane.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Source/Core/DolphinQt2/Settings/GameCubePane.cpp b/Source/Core/DolphinQt2/Settings/GameCubePane.cpp index bea623784a..0fbb68f802 100644 --- a/Source/Core/DolphinQt2/Settings/GameCubePane.cpp +++ b/Source/Core/DolphinQt2/Settings/GameCubePane.cpp @@ -116,6 +116,8 @@ void GameCubePane::CreateWidgets() layout->addWidget(ipl_box); layout->addWidget(device_box); + layout->addStretch(); + setLayout(layout); } From 2d0d4fee288309d932d57fde8d578f6ee9e5140a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9o=20Lam?= Date: Sat, 24 Mar 2018 18:45:10 +0100 Subject: [PATCH 5/5] Qt: Fix controller window margin Reduces wasted space and makes the whole window (barely) fit on my laptop screen again. (Regression from the scroll wrap changes) --- Source/Core/DolphinQt2/QtUtils/WrapInScrollArea.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/DolphinQt2/QtUtils/WrapInScrollArea.cpp b/Source/Core/DolphinQt2/QtUtils/WrapInScrollArea.cpp index 4dc524cd8e..1327092bb3 100644 --- a/Source/Core/DolphinQt2/QtUtils/WrapInScrollArea.cpp +++ b/Source/Core/DolphinQt2/QtUtils/WrapInScrollArea.cpp @@ -40,7 +40,7 @@ void WrapInScrollArea(QWidget* parent, QLayout* wrapped_layout, QWidget* to_resi auto* widget = new QWidget; widget->setLayout(wrapped_layout); - auto* scroll_area = GetWrappedWidget(widget, to_resize); + auto* scroll_area = GetWrappedWidget(widget, to_resize, 0, 0); auto* scroll_layout = new QVBoxLayout; scroll_layout->addWidget(scroll_area);