diff --git a/Source/Core/Common/BitField.h b/Source/Core/Common/BitField.h index 10312f1c38..35d294d220 100644 --- a/Source/Core/Common/BitField.h +++ b/Source/Core/Common/BitField.h @@ -121,7 +121,7 @@ private: public: // Force default constructor to be created // so that we can use this within unions - BitField() = default; + constexpr BitField() = default; // We explicitly delete the copy assignment operator here, because the // default copy assignment would copy the full storage value, rather than @@ -139,20 +139,8 @@ public: return *this; } - __forceinline T Value() const - { - if (std::numeric_limits::is_signed) - { - std::size_t shift = 8 * sizeof(T) - bits; - return (T)((storage << (shift - position)) >> shift); - } - else - { - return (T)((storage & GetMask()) >> position); - } - } - - __forceinline operator T() const { return Value(); } + constexpr T Value() const { return Value(std::is_signed()); } + constexpr operator T() const { return Value(); } private: // StorageType is T for non-enum types and the underlying type of T if // T is an enumeration. Note that T is wrapped within an enable_if in the @@ -161,10 +149,21 @@ private: typedef typename std::conditional::value, std::underlying_type, std::enable_if>::type::type StorageType; + constexpr T Value(std::true_type) const + { + using shift_amount = std::integral_constant; + return static_cast((storage << (shift_amount() - position)) >> shift_amount()); + } + + constexpr T Value(std::false_type) const + { + return static_cast((storage & GetMask()) >> position); + } + // Unsigned version of StorageType typedef typename std::make_unsigned::type StorageTypeU; - __forceinline StorageType GetMask() const + static constexpr StorageType GetMask() { return (((StorageTypeU)~0) >> (8 * sizeof(T) - bits)) << position; }