The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-03-12 14:46:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix a memory leak in ExpressionParser.cpp

Browse Source 
Because there's a return here, expr should be deleted since it's not assigned to anything before returning.
This commit is contained in:
Lioncash 2013-08-08 17:56:15 -04:00
parent 72abe7c654
commit cce809ac90
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Source/Core/InputCommon/Src/ControllerInterface/ExpressionParser.cpp
View File

@ -549,7 +549,10 @@ ExpressionParseStatus ParseExpressionInner(std::string str, ControlFinder &finde
Parser p(tokens, finder); Parser p(tokens, finder);
status = p.Parse(&expr); status = p.Parse(&expr);
if (status != EXPRESSION_PARSE_SUCCESS) if (status != EXPRESSION_PARSE_SUCCESS)
{
delete expr;
return status; return status;
}
*expr_out = expr; *expr_out = expr;
return EXPRESSION_PARSE_SUCCESS; return EXPRESSION_PARSE_SUCCESS;