diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivity.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivity.java index 5d76d69363..2e297050ee 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivity.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivity.java @@ -182,7 +182,8 @@ public final class SettingsActivity extends AppCompatActivity implements Setting // If the user picked a file, as opposed to just backing out. if (resultCode == MainActivity.RESULT_OK) { - mPresenter.onFileConfirmed(FileBrowserHelper.getSelectedPath(result)); + String path = FileBrowserHelper.getSelectedPath(result); + getFragment().getAdapter().onFilePickerConfirmation(path); // Prevent duplicate Toasts. if (!mPresenter.shouldSave()) diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityPresenter.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityPresenter.java index 71c47cbe01..34e8ba2a10 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityPresenter.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityPresenter.java @@ -231,9 +231,4 @@ public final class SettingsActivityPresenter mView.showSettingsFragment(menuTag, bundle, true, gameId); } } - - public void onFileConfirmed(String file) - { - SettingsAdapter.onFilePickerConfirmation(file); - } } diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsAdapter.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsAdapter.java index e2b387a049..1f2a7ab9dd 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsAdapter.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsAdapter.java @@ -56,7 +56,6 @@ public final class SettingsAdapter extends RecyclerView.Adapter mSettings; @@ -67,14 +66,9 @@ public final class SettingsAdapter extends RecyclerView.Adapter extensions; - switch (sFilePicker.getRequestType()) + switch (filePicker.getRequestType()) { case MainPresenter.REQUEST_SD_FILE: extensions = FileBrowserHelper.RAW_EXTENSION; @@ -330,17 +323,22 @@ public final class SettingsAdapter extends RecyclerView.Adapter entry : SettingsFragmentPresenter.LOG_TYPE_NAMES.entrySet()) { - sView.putSetting(new StringSetting(entry.getKey(), Settings.SECTION_LOGGER_LOGS, value)); + mView.putSetting(new StringSetting(entry.getKey(), Settings.SECTION_LOGGER_LOGS, value)); } - sView.onSettingChanged(null); + mView.onSettingChanged(null); } private void handleMenuTag(MenuTag menuTag, int value) diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragment.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragment.java index 69444b90c0..28fae8ac3d 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragment.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragment.java @@ -168,6 +168,12 @@ public final class SettingsFragment extends Fragment implements SettingsFragment mPresenter.loadDefaultSettings(); } + @Override + public SettingsAdapter getAdapter() + { + return mAdapter; + } + @Override public void loadSubMenu(MenuTag menuKey) { diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentPresenter.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentPresenter.java index 5c0ce066a4..b72f2597b0 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentPresenter.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentPresenter.java @@ -355,7 +355,7 @@ public final class SettingsFragmentPresenter Settings.SECTION_INI_GENERAL, R.string.SD_card_path, 0, getDefaultSDPath(), MainPresenter.REQUEST_SD_FILE, wiiSDCardPath)); sl.add(new ConfirmRunnable(R.string.reset_paths, 0, R.string.reset_paths_confirmation, 0, - SettingsAdapter::resetPaths)); + mView.getAdapter()::resetPaths)); } private void addGameCubeSettings(ArrayList sl) @@ -739,11 +739,9 @@ public final class SettingsFragmentPresenter R.string.log_verbosity, 0, getLogVerbosityEntries(), getLogVerbosityValues(), 1, logVerbosity)); sl.add(new ConfirmRunnable(R.string.log_enable_all, 0, R.string.log_enable_all_confirmation, 0, - () -> SettingsAdapter.setAllLogTypes("True"))); - sl.add( - new ConfirmRunnable(R.string.log_disable_all, 0, R.string.log_disable_all_confirmation, - 0, - () -> SettingsAdapter.setAllLogTypes("False"))); + () -> mView.getAdapter().setAllLogTypes("True"))); + sl.add(new ConfirmRunnable(R.string.log_disable_all, 0, R.string.log_disable_all_confirmation, + 0, () -> mView.getAdapter().setAllLogTypes("False"))); sl.add(new HeaderSetting(null, null, R.string.log_types, 0)); for (Map.Entry entry : LOG_TYPE_NAMES.entrySet()) diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentView.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentView.java index 6de8b0f110..7c976535b2 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentView.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentView.java @@ -40,6 +40,11 @@ public interface SettingsFragmentView */ FragmentActivity getActivity(); + /** + * @return The Fragment's SettingsAdapter. + */ + SettingsAdapter getAdapter(); + /** * Tell the Fragment to tell the containing Activity to show a new * Fragment containing a submenu of settings.