From d981944d7cad89841af60d9cc36b59ede6a089c1 Mon Sep 17 00:00:00 2001 From: Pokechu22 Date: Thu, 23 Dec 2021 12:33:28 -0800 Subject: [PATCH] FifoPlayer: Fix uninitialized variable warnings in ClearEfb The actual values don't matter since we overwrite all of the relevant fields, but other bits were not initialized (e.g. the top 12 bits of X10Y10), so the warning was semi-valid. --- Source/Core/Core/FifoPlayer/FifoPlayer.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Source/Core/Core/FifoPlayer/FifoPlayer.cpp b/Source/Core/Core/FifoPlayer/FifoPlayer.cpp index 58add3faaa..0d1887cd82 100644 --- a/Source/Core/Core/FifoPlayer/FifoPlayer.cpp +++ b/Source/Core/Core/FifoPlayer/FifoPlayer.cpp @@ -571,18 +571,18 @@ void FifoPlayer::ClearEfb() // Trigger a bogus EFB copy to clear the screen // The target address is 0, and there shouldn't be anything there, // but even if there is it should be loaded in by LoadTextureMemory afterwards - X10Y10 tl; + X10Y10 tl = bpmem.copyTexSrcXY; tl.x = 0; tl.y = 0; LoadBPReg(BPMEM_EFB_TL, tl.hex); - X10Y10 wh; + X10Y10 wh = bpmem.copyTexSrcWH; wh.x = EFB_WIDTH - 1; wh.y = EFB_HEIGHT - 1; LoadBPReg(BPMEM_EFB_WH, wh.hex); LoadBPReg(BPMEM_MIPMAP_STRIDE, 0x140); // The clear color and Z value have already been loaded via LoadRegisters() LoadBPReg(BPMEM_EFB_ADDR, 0); - UPE_Copy copy; + UPE_Copy copy = bpmem.triggerEFBCopy; copy.clamp_top = false; copy.clamp_bottom = false; copy.yuv = false;