The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-02-03 11:32:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use correct CRC16s

Browse Source 
Libogc has a bit of a footgun, where __io_gcsda.isInserted() will initialize the card, but not the CRC tables; __io_gcsda.startup() needs to be called first.
This commit is contained in:
Pokechu22 2020-08-23 16:23:02 -07:00
parent c80c323a26
commit d98be4bdc9
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Source/Core/Core/HW/EXI/EXI_DeviceSD.cpp
View File

@ -235,9 +235,9 @@ void CEXISD::WriteByte(u8 byte)
response.push_back(0xc0);
response.push_back(0x40);
response.push_back(0x01 | (crc << 1));
// Surprisingly, this thing's CRC16 is 0. Probably shouldn't be hardcoded still.
response.push_back(0);
response.push_back(0);
// Hardcoded CRC16 (0x6a74)
response.push_back(0x6a);
response.push_back(0x74);
}
else if (cmd[0] == 0x4A) // SEND_CID
{
@ -262,9 +262,9 @@ void CEXISD::WriteByte(u8 byte)
response.push_back(0x08);
response.push_back(0x00);
response.push_back(0x00);
// Very dubiously, this thing's CRC16 is ALSO 0. At least per libogc...
response.push_back(0);
response.push_back(0);
// Hardcoded CRC16 (0x9e3e)
response.push_back(0x9e);
response.push_back(0x3e);
}
else if (cmd[0] == 0x4c) // STOP_TRANSMISSION
{
@ -289,7 +289,7 @@ void CEXISD::WriteByte(u8 byte)
{
response.push_back(0);
}
// CRC - I think libogc must be broken
// This CRC16 is 0, probably since the data is all 0
response.push_back(0);
response.push_back(0);
}