The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-02-13 15:59:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

VideoCommon: Zero PortableVertexDeclarations on initialization

Browse Source 
Fixes an issue where the default initializer wouldn't initialize padding, making for fun non-determinism
This commit is contained in:
TellowKrinkle 2022-11-03 02:25:08 -05:00
parent 1d07332657
commit d9ed9ae331
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/VideoCommon/NativeVertexFormat.h
View File

@ -63,6 +63,9 @@ struct PortableVertexDeclaration
std::array<AttributeFormat, 8> texcoords; std::array<AttributeFormat, 8> texcoords;
AttributeFormat posmtx; AttributeFormat posmtx;
// Make sure we initialize padding to 0 since padding is included in the == memcmp
PortableVertexDeclaration() { memset(this, 0, sizeof(*this)); }
inline bool operator<(const PortableVertexDeclaration& b) const inline bool operator<(const PortableVertexDeclaration& b) const
{ {
return memcmp(this, &b, sizeof(PortableVertexDeclaration)) < 0; return memcmp(this, &b, sizeof(PortableVertexDeclaration)) < 0;
@ -73,6 +76,9 @@ struct PortableVertexDeclaration
} }
}; };
static_assert(std::is_trivially_copyable_v<PortableVertexDeclaration>,
"Make sure we can memset-initialize");
namespace std namespace std
{ {
template <> template <>