From 7dec083af5ebb99d1a3269b5f523b55bfe939d51 Mon Sep 17 00:00:00 2001 From: Javier Martinez Date: Fri, 31 Jan 2025 12:26:33 -0500 Subject: [PATCH] Refactor: Make loop non-infinite instead in AsyncShaderCompiler. --- Source/Core/VideoCommon/AsyncShaderCompiler.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Source/Core/VideoCommon/AsyncShaderCompiler.cpp b/Source/Core/VideoCommon/AsyncShaderCompiler.cpp index ca59ee6330..c69354628d 100644 --- a/Source/Core/VideoCommon/AsyncShaderCompiler.cpp +++ b/Source/Core/VideoCommon/AsyncShaderCompiler.cpp @@ -95,23 +95,20 @@ bool AsyncShaderCompiler::WaitUntilCompletion( } // Update progress while the compiles complete. - for (;;) + while (Core::GetState(Core::System::GetInstance()) != Core::State::Stopping) { - if (Core::GetState(Core::System::GetInstance()) == Core::State::Stopping) - return false; - size_t remaining_items; { std::lock_guard pending_guard(m_pending_work_lock); if (m_pending_work.empty() && !m_busy_workers.load()) - break; + return true; remaining_items = m_pending_work.size(); } progress_callback(total_items - remaining_items, total_items); std::this_thread::sleep_for(CHECK_INTERVAL); } - return true; + return false; } bool AsyncShaderCompiler::StartWorkerThreads(u32 num_worker_threads)