From ded2d55438fa010cd162c9f77d97ad530f89bb24 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 12 Dec 2023 14:03:39 -0500 Subject: [PATCH] ExpressionParser: Avoid some miscellaneous copies Just some trivial copies that can be eliminated or turned into moves. --- .../Core/InputCommon/ControlReference/ExpressionParser.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp b/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp index 1c6b00c715..414a5aa888 100644 --- a/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp +++ b/Source/Core/InputCommon/ControlReference/ExpressionParser.cpp @@ -248,7 +248,7 @@ ParseStatus Lexer::Tokenize(std::vector& tokens) class ControlExpression : public Expression { public: - explicit ControlExpression(ControlQualifier qualifier) : m_qualifier(qualifier) {} + explicit ControlExpression(ControlQualifier qualifier) : m_qualifier(std::move(qualifier)) {} ControlState GetValue() const override { @@ -448,7 +448,7 @@ private: const ControlState m_value{}; }; -static ParseResult MakeLiteralExpression(Token token) +static ParseResult MakeLiteralExpression(const Token& token) { ControlState val{}; if (TryParse(token.data, &val)) @@ -460,7 +460,7 @@ static ParseResult MakeLiteralExpression(Token token) class VariableExpression : public Expression { public: - explicit VariableExpression(std::string name) : m_name(name) {} + explicit VariableExpression(std::string name) : m_name(std::move(name)) {} ControlState GetValue() const override { return m_variable_ptr ? *m_variable_ptr : 0; }