From ee434d4f015522dd162cb343f541a6cd32f5bfcb Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sun, 27 May 2018 21:26:47 -0400 Subject: [PATCH] Common: Remove unnecessary ~9 year old LOGGING preprocessor define This was added in 4bdb4aa0d1c8520488583ba79c9f5ab6e5656eca back in 2009-02-27. The only usage spot of this macro involves the same checks that were used to define that preprocessor macro, so we can simply remove the macro --- Source/Core/Common/Common.h | 7 ------- Source/Core/Common/Logging/Log.h | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/Source/Core/Common/Common.h b/Source/Core/Common/Common.h index 17b53b2bf5..b1f7207734 100644 --- a/Source/Core/Common/Common.h +++ b/Source/Core/Common/Common.h @@ -4,13 +4,6 @@ #pragma once -// Force enable logging in the right modes. For some reason, something had changed -// so that debugfast no longer logged. -#if defined(_DEBUG) || defined(DEBUGFAST) -#undef LOGGING -#define LOGGING 1 -#endif - #if defined(__GNUC__) || __clang__ // Disable "unused function" warnings for the ones manually marked as such. #define UNUSED __attribute__((unused)) diff --git a/Source/Core/Common/Logging/Log.h b/Source/Core/Common/Logging/Log.h index 7e7b295a52..54c9bc6d1f 100644 --- a/Source/Core/Common/Logging/Log.h +++ b/Source/Core/Common/Logging/Log.h @@ -81,7 +81,7 @@ void GenericLog(LogTypes::LOG_LEVELS level, LogTypes::LOG_TYPE type, const char* #endif ; -#if defined LOGGING || defined _DEBUG || defined DEBUGFAST +#if defined(_DEBUG) || defined(DEBUGFAST) #define MAX_LOGLEVEL LogTypes::LOG_LEVELS::LDEBUG #else #ifndef MAX_LOGLEVEL