From f25bdda72877b9e09cc9c1985c51721d4194dceb Mon Sep 17 00:00:00 2001 From: LillyJadeKatrin Date: Sat, 27 Jan 2024 18:50:27 -0500 Subject: [PATCH] Removed post data from Achievement request logs post_data included passwords and API keys in plaintext so continuing to include it in logs is a security liability. --- Source/Core/Core/AchievementManager.cpp | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/Source/Core/Core/AchievementManager.cpp b/Source/Core/Core/AchievementManager.cpp index 0d8a18fdc3..eb5bc2a891 100644 --- a/Source/Core/Core/AchievementManager.cpp +++ b/Source/Core/Core/AchievementManager.cpp @@ -1631,10 +1631,8 @@ AchievementManager::ResponseType AchievementManager::Request( const std::string response_str(http_response->begin(), http_response->end()); if (process_response(rc_response, response_str.c_str()) != RC_OK) { - ERROR_LOG_FMT( - ACHIEVEMENTS, "Failed to process HTTP response. \nURL: {} \npost_data: {} \nresponse: {}", - api_request.url, api_request.post_data == nullptr ? "NULL" : api_request.post_data, - response_str); + ERROR_LOG_FMT(ACHIEVEMENTS, "Failed to process HTTP response. \nURL: {} \nresponse: {}", + api_request.url, response_str); return ResponseType::MALFORMED_OBJECT; } if (rc_response->response.succeeded) @@ -1650,9 +1648,7 @@ AchievementManager::ResponseType AchievementManager::Request( } else { - WARN_LOG_FMT(ACHIEVEMENTS, "RetroAchievements connection failed. \nURL: {} \npost_data: {}", - api_request.url, - api_request.post_data == nullptr ? "NULL" : api_request.post_data); + WARN_LOG_FMT(ACHIEVEMENTS, "RetroAchievements connection failed. \nURL: {}", api_request.url); return ResponseType::CONNECTION_FAILED; } }